Skip to content

Fix: enable exclude filter for validation, rework partial update detection#724

Merged
renatav merged 9 commits intomasterfrom
sbojanic/enable-repo-exclusion-for-validation
Apr 20, 2026
Merged

Fix: enable exclude filter for validation, rework partial update detection#724
renatav merged 9 commits intomasterfrom
sbojanic/enable-repo-exclusion-for-validation

Conversation

@sale3
Copy link
Copy Markdown
Contributor

@sale3 sale3 commented Apr 16, 2026

Description (e.g. "Related to ...", etc.)

Reworks partial-update detection for exclude-filter flows. Updates with excluded targets are no longer treated as partial when all included repositories validate successfully, and last_validated_commit is now persisted for those runs.

Tested the following:

  • Cloned with repo clone --exclude-filter "repo['type']=='html'" git@github.com:oll-test-repos/mohicanlaw-law.git

  • Ran taf repo update and confirmed that the html repo was not cloned

  • Deleted the exclude-filter entry from last_validated_commit and confirmed that the repo was cloned as expected

  • Deleted last_validated_commit and ran update, condifrming that the validation started from the beginning and was completed successfully.

  • Ran integration tests

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)

  • Title summarizes what is changing

  • Commit messages are meaningful (see this for details)

  • Tests have been included and/or updated, as appropriate
    Docstrings have been included and/or updated, as appropriate

  • Changelog has been updated, as needed (see CHANGELOG.md)

@sale3 sale3 force-pushed the sbojanic/enable-repo-exclusion-for-validation branch from fddcaa2 to 9bed458 Compare April 16, 2026 20:43
@sale3 sale3 requested a review from renatav April 16, 2026 20:43
@sale3 sale3 self-assigned this Apr 16, 2026
@sale3 sale3 force-pushed the sbojanic/enable-repo-exclusion-for-validation branch from 9bed458 to 43b4110 Compare April 16, 2026 20:59
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 17, 2026

CLA assistant check
All committers have signed the CLA.

@renatav renatav force-pushed the sbojanic/enable-repo-exclusion-for-validation branch from 4250190 to 8da1f5e Compare April 17, 2026 21:21
@renatav renatav force-pushed the sbojanic/enable-repo-exclusion-for-validation branch from 64c4a78 to e6af025 Compare April 17, 2026 23:42
@renatav renatav requested a review from n-dusan April 20, 2026 09:38
@renatav renatav changed the title Fix: enable exclude filter for validation Fix: enable exclude filter for validation, rework partial update detection Apr 20, 2026
@renatav renatav removed their request for review April 20, 2026 09:42
@renatav renatav self-assigned this Apr 20, 2026
Copy link
Copy Markdown
Contributor

@n-dusan n-dusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question (non-blocking): is it worth adding tests for exclude-filter scenarios to reduce the need for manual testing, especially once codify rolls out?

@renatav renatav merged commit 22e77d3 into master Apr 20, 2026
10 checks passed
@renatav renatav deleted the sbojanic/enable-repo-exclusion-for-validation branch April 20, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants