Conversation
fddcaa2 to
9bed458
Compare
9bed458 to
43b4110
Compare
4250190 to
8da1f5e
Compare
64c4a78 to
e6af025
Compare
n-dusan
approved these changes
Apr 20, 2026
Contributor
n-dusan
left a comment
There was a problem hiding this comment.
question (non-blocking): is it worth adding tests for exclude-filter scenarios to reduce the need for manual testing, especially once codify rolls out?
n-dusan
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (e.g. "Related to ...", etc.)
Reworks partial-update detection for exclude-filter flows. Updates with excluded targets are no longer treated as partial when all included repositories validate successfully, and last_validated_commit is now persisted for those runs.
Tested the following:
Cloned with
repo clone --exclude-filter "repo['type']=='html'" git@github.com:oll-test-repos/mohicanlaw-law.gitRan
taf repo updateand confirmed that the html repo was not clonedDeleted the
exclude-filterentry fromlast_validated_commitand confirmed that the repo was cloned as expectedDeleted
last_validated_commitand ran update, condifrming that the validation started from the beginning and was completed successfully.Ran integration tests
Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
Title summarizes what is changing
Commit messages are meaningful (see this for details)
Tests have been included and/or updated, as appropriate
Docstrings have been included and/or updated, as appropriateChangelog has been updated, as needed (see CHANGELOG.md)