feat: relations

[vertex451]

Resolves #254

Testing

Tested 15.08 at 44afd8b commit in local-setup

Demo

and CRD:

[pteich]

I left some comments and suggestions.

[pteich]

Please switch the logic and return something in case of an error and do a proper "happy path" return at the end of the function.

and maybe als return the error - why is there an error return value anyway

[vertex451]

improved error handling

[pteich]

This circular dependency between the relation resolver and the service feels bad. Especially as the RelationResolver is no external dependency that is passed to the New function of the service. So it's not replaceable and has no further meaning besides adding unnecessary complexity and get an OOP feeling 😅.

I would add the functions it to the service itself and rename the CreateResolver to RelationResolver of the service.

[vertex451]

You are right, no need to isolate it for now, moved methods under the service receiver.

[pteich]

It's the same circular dependency as above. I don't really see a need to separate it in another struct. You don't have an possibility to add a different RelationEnhancer so it makes no sense. I would move the methods to the Gateway. You can however keep it in a separate file.

[vertex451]

You are not going to believe - I seen those deps, but decided to go with them since it is in the same package.
But eventually you have the point - no need to move it under a different struct.

[pteich]

Using strings.Compare should be a better approach:

Suggested change

	for kindKey, infos := range b.kindRegistry {
	slices.SortFunc(infos, func(a, b ResourceInfo) int {
	if a.Group != b.Group {
	if a.Group < b.Group {
	return -1
	}
	return 1
	}
	if a.Version != b.Version {
	if a.Version < b.Version {
	return -1
	}
	return 1
	}
	if a.Kind != b.Kind {
	if a.Kind < b.Kind {
	return -1
	}
	return 1
	}
	if a.SchemaKey < b.SchemaKey {
	return -1
	}
	if a.SchemaKey > b.SchemaKey {
	return 1
	}
	return 0
	})
	b.kindRegistry[kindKey] = infos
	}
	for kindKey, infos := range b.kindRegistry {
	slices.SortFunc(infos, func(a, b ResourceInfo) int {
	if cmp := strings.Compare(a.Group, b.Group); cmp != 0 {
	return cmp
	}
	if cmp := strings.Compare(a.Version, b.Version); cmp != 0 {
	return cmp
	}
	if cmp := strings.Compare(a.Kind, b.Kind); cmp != 0 {
	return cmp
	}
	return strings.Compare(a.SchemaKey, b.SchemaKey)
	})
	b.kindRegistry[kindKey] = infos
	}

[vertex451]

Much cleaner approach, thanks!