Open
Conversation
* add support for mysql 8 database * add support for mysql 8 database * add documentation * Update README.md Co-authored-by: Ruhanga <41738040+Ruhanga@users.noreply.github.com> * Update README.md Co-authored-by: Ruhanga <41738040+Ruhanga@users.noreply.github.com> * Update example-app/application.properties Co-authored-by: Ruhanga <41738040+Ruhanga@users.noreply.github.com> * Update example-app/application.properties Co-authored-by: Ruhanga <41738040+Ruhanga@users.noreply.github.com> * Update example-app/application.properties Co-authored-by: Ruhanga <41738040+Ruhanga@users.noreply.github.com> * Update README.md --------- Co-authored-by: Ruhanga <41738040+Ruhanga@users.noreply.github.com> (cherry picked from commit 7eef172)
njiddasalifu
approved these changes
May 21, 2024
njiddasalifu
left a comment
njiddasalifu
left a comment
There was a problem hiding this comment.
Looks okay to me.
Just have one question.Why do we always have to manual hard code version numbers?I was wondering if there is a wy those numbers comes automatically when trigered, I notice even for a release it's still to manually modify the next version.
Just wish to know why it's always this way. @icrc-fdeniger @mks-d @maimoonak
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.