O3-5503: Fix duplicate patient property and missing visit property in QueueEntrySubResource RefRepresentation#103
Open
Conversation
… property and missing visit property
There was a problem hiding this comment.
Pull request overview
Fixes a copy-paste bug in QueueEntrySubResource where the patient property was added twice in the RefRepresentation block instead of adding patient and visit.
Changes:
- Replaced duplicate
patientproperty withvisitin the RefRepresentation description
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Clean and straightforward fix. The evidence provided clearly confirms this is a copy-paste error — DefaultRepresentation and FullRepresentation both correctly include visit, so this one-line fix is consistent with the rest of the file. Good catch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
QueueEntrySubResource#getRepresentationDescription()has a copy-paste error in theRefRepresentationblock: thepatientproperty is added twice, while thevisitproperty is missing entirely.This means REST API responses from
/ws/rest/v1/queue/{uuid}/entrywithv=refrepresentation include redundant patient data and omit visit data.Changes
One-line fix: replaced the duplicate
patientproperty declaration withvisiton line 157.Evidence
The DefaultRepresentation and FullRepresentation in the same file both correctly include visit. The parent resource (QueueEntryResource.java) also correctly includes both patient and visit in its RefRepresentation.
Issue
O3-5503