- 
                Notifications
    
You must be signed in to change notification settings  - Fork 77
 
          fix: enable using the direct queue for isr
          #319
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          🦋 Changeset detectedLatest commit: 4fb97c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
 Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR  | 
    
          
commit:   | 
    
28587f4    to
    b399584      
    Compare
  
    | 
           Awesome 🎉 I'll try to review the PR tomorrow afternoon!  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this will work and could be used right now to make ISR work, i think a better solution long term would be to use a queue system for deduplicating the revalidation.
With the direct queue, once a page is stale, every request for this page (while it is revalidating and available worldwide) will trigger a new revalidation.
KV will probably throw a lot of error because of the 1s write per key limitations
          
 Agreed, I had wrote on the issue that we should do it as an additional piece of work separately to this - both should be available for people to use ideally.  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase and try to upstream the change?
b399584    to
    229b2e2      
    Compare
  
    
          
 I've opened opennextjs/opennextjs-aws#728 to upstream it.  | 
    
229b2e2    to
    fa3b420      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update 🚀
directfor the queue.