Refactor BLE pairing, whitelist, and advertising#107
Merged
zjwhitehead merged 1 commit intomasterfrom Mar 27, 2026
Merged
Conversation
Add pairingModeTransitionActive to suppress advertising restarts during bond-clear transitions and prevent advertising while the whitelist is being modified. Replace clearWhiteList with syncWhiteListFromBonds that prunes stale whitelist entries and only adds missing bonded addresses, and ensure advertising is stopped before changing whitelist to avoid BLE_HS_EBUSY. Make startAdvertising respect the transition flag and avoid immediate restarts from onDisconnect during transitions. Implement enterBLEPairingMode to safely disconnect, stop advertising, and clear bonds (with retries), and add BLE_PAIRING_HOLD_MS plus related button-handler changes to enter pairing mode on a long hold (removing the previous multi-tier unbond/delete flow). These changes improve robustness of whitelist and pairing operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pairingModeTransitionActive to suppress advertising restarts during bond-clear transitions and prevent advertising while the whitelist is being modified. Replace clearWhiteList with syncWhiteListFromBonds that prunes stale whitelist entries and only adds missing bonded addresses, and ensure advertising is stopped before changing whitelist to avoid BLE_HS_EBUSY. Make startAdvertising respect the transition flag and avoid immediate restarts from onDisconnect during transitions. Implement enterBLEPairingMode to safely disconnect, stop advertising, and clear bonds (with retries), and add BLE_PAIRING_HOLD_MS plus related button-handler changes to enter pairing mode on a long hold (removing the previous multi-tier unbond/delete flow). These changes improve robustness of whitelist and pairing operations.