-
Notifications
You must be signed in to change notification settings - Fork 90
Enhance FinalClass with new exclusion options and includeNeverExtended option #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/main/java/org/openrewrite/staticanalysis/FinalClass.java
- lines 61-61
src/test/java/org/openrewrite/staticanalysis/FinalClassTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/main/java/org/openrewrite/staticanalysis/FinalClass.java
- lines 61-62
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/main/java/org/openrewrite/staticanalysis/FinalClass.java
- lines 61-62
What's changed?
includeNeverExtendedoption that allows to finalize classes that are never extended in the codebaseexcludePackagesoption for package pattern exclusions (e.g.,com.example.api.*)excludeAnnotationsoption to exclude classes with specified annotations (annotations like:@Deprecated,Deprecated,@java.lang.Deprecated)What's your motivation?
FinalClassandHideUtilityClassConstructorshould not apply for Spring Configuration classes #729@timtebeek - FYI.
Checklist