Skip to content

Conversation

@znicholls
Copy link
Collaborator

@znicholls znicholls commented Feb 15, 2021

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable) (N/A)
  • Example added (either to an existing notebook or as a new notebook, where applicable)
  • Description in CHANGELOG.rst added

Closes #141

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <https://github.com/openscm/scmdata/pull/XX>`_) Added feature which does something
- (`#XX <https://github.com/openscm/scmdata/pull/XX>`_) Fixed bug identified in (`#YY <https://github.com/openscm/scmdata/issues/YY>`_)

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #143 (136d60e) into master (a73a239) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   93.78%   93.83%   +0.04%     
==========================================
  Files          15       15              
  Lines        1610     1622      +12     
  Branches      326      327       +1     
==========================================
+ Hits         1510     1522      +12     
  Misses         79       79              
  Partials       21       21              
Impacted Files Coverage Δ
src/scmdata/netcdf.py 95.91% <100.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a73a239...136d60e. Read the comment docs.

@znicholls
Copy link
Collaborator Author

znicholls commented Feb 15, 2021

Part of the solution was in #129

@znicholls znicholls requested a review from lewisjared February 15, 2021 05:12
@lewisjared lewisjared merged commit 37b76f8 into master Feb 18, 2021
@znicholls znicholls deleted the time-axis-serialisation branch February 18, 2021 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better time description when saving netCDF

3 participants