-
Notifications
You must be signed in to change notification settings - Fork 72
Add release Go/No-Go vote issue template (for async decision) #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
d715232
eda5faa
ffd1cb9
2907023
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,60 @@ | ||||||||||||||||||||||||
| --- | ||||||||||||||||||||||||
| name: π Release Go/No-Go Vote | ||||||||||||||||||||||||
| about: Async Go/No-Go decision for OpenSearch release | ||||||||||||||||||||||||
| title: '[RELEASE] Go/No-Go Vote - OpenSearch <VERSION>' | ||||||||||||||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||||||
| labels: 'release' | ||||||||||||||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We dont have |
||||||||||||||||||||||||
| assignees: '' | ||||||||||||||||||||||||
| --- | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| ## Voting Window | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| **Date:** <DATE> | ||||||||||||||||||||||||
| **Time:** 8:00 AM PST β 8:00 PM PST | ||||||||||||||||||||||||
|
Comment on lines
+11
to
+12
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I will like to keep an extended 12 hour window atleast to overlap with all the regions. |
||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| ## Release References | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| - **Release Issue:** [opensearch-project/opensearch-build#XXXX](https://github.com/opensearch-project/opensearch-build/issues/XXXX) | ||||||||||||||||||||||||
| - **Release Notes Draft:** <LINK> | ||||||||||||||||||||||||
| - **Build Status:** <LINK> | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| ## How to Vote | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| - **Go:** React with π on the **Go** comment below | ||||||||||||||||||||||||
| - **No-Go:** React with π on the **No-Go** comment below **and** leave a comment with your reasoning so we can follow through | ||||||||||||||||||||||||
|
Comment on lines
+22
to
+23
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Comments are probably better than reactions for this. Comments provide a audit trail that I'm not sure we'd get with reactions. If the concern raised in a -1 comment is addressed, that comment can be marked as outdated and the commenter can add a subsequent +1 comment. Reactions can be changed with little or visibility into when or why the change happened.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. One concern with using comments for everything though is with many voters, the Go comments could drown out the No-Go discussions that actually need attention. How about a hybrid approach:
The audit trail matters most for No-Go votes since those are the ones that need tracking and resolution. Mandatory voters always comment to ensure accountability for the votes that gate the release. Thoughts?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually the original text is probably okay. The no-go comments are sufficient as the audit trail. As soon as the first mandatory voter leaves a +1 comment then others will pile on without reading :)
Comment on lines
+22
to
+23
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| ## Mandatory Votes | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| | Role | GitHub Handle | Vote | | ||||||||||||||||||||||||
| |------|--------------|------| | ||||||||||||||||||||||||
| | Release Manager | @ | | | ||||||||||||||||||||||||
| | OS Core Maintainer (1+) | @ | | | ||||||||||||||||||||||||
| | Documentation Maintainer | @ | | | ||||||||||||||||||||||||
| | Website Maintainer | @ | | | ||||||||||||||||||||||||
| | Release Blog Owner | @ | | | ||||||||||||||||||||||||
|
Comment on lines
+30
to
+33
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add OSD core owners here as well.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OSD and all other plugins will have equal say in the vote (Go/No-Go). Only core maintainer needs to be mandatory as it is the dependency for all . |
||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| ## Voting Rules | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| - A No-Go vote from any mandatory voter or maintainer of any `opensearch-project` repo blocks the release. No-Go votes must include an explicit comment with reasoning. | ||||||||||||||||||||||||
| - A No-Go vote from any community member or OpenSearch user will be reviewed, with the final decision resting on the maintainer of the respective repo related to the concern. | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| ## Discussion | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| For questions and discussion, use the Slack thread in #releases: <SLACK_THREAD_LINK> | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| > The Release Manager is responsible for surfacing any No-Go concerns raised in Slack as comments on this issue to ensure they are formally captured. | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| ## Other Maintainers & Contributors | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| All maintainers and community members are encouraged to vote using π (Go) or π (No-Go) reactions on the respective comments below. | ||||||||||||||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was discussed previously above: #485 (comment) |
||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| ## Release Checklist | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| - [ ] All release-blocking issues resolved | ||||||||||||||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If possible, would be good to include links here to release related issues (to
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. agreed, voters need easy access to the release status to make an informed decision. Adding a "Release References" section to the template with links to the |
||||||||||||||||||||||||
| - [ ] Documentation ready | ||||||||||||||||||||||||
| - [ ] Release blog drafted | ||||||||||||||||||||||||
| - [ ] Website updates prepared | ||||||||||||||||||||||||
| - [ ] CI/CD pipelines green | ||||||||||||||||||||||||
|
Comment on lines
+52
to
+56
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Easier to insert sub-bulletin list of what is not ready
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove website part because that is a few clicks on WP.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can iterate on it as we learn from the releases. On website, its readiness is the key, which should have a checklist. |
||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| ## Additional Context | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| _Add any relevant links, notes, or context for this release._ | ||||||||||||||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A GitHub issue is the right place for capturing votes and any concerns related to a -1 vote. However, they don't work well for lengthy discussions and questions. Should we create a section for a link to a slack thread in the releases channel? There's a risk of bifurcating the discussion, but slack lends itself better to questions and ephemeral discussion. What do you think?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's a fair point. The issue stays the source of truth for votes and No-Go reasoning, while Slack handles the back-and-forth discussion. To avoid bifurcation, the template can make it clear:
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I do agree that the GitHub issue is a great way forward for this but share the concerns for keeping records of the discussion. Another option I want to throw out there is the Forum - these conversations are a LOT easier to find than Slack threads - and are a lot more legible. Slack is a quick conversation place, but if we want them long-term, consider the forum. I could even create a specific place for these if we wanted.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
@krisfreedain The slack channel would just be for ephemeral discussion about the immediate release. It would be the responsibility of the release manager to ensure that anything that wasn't ephemeral discussion got captured in the GitHub issue.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Makes sense. Good to ensure that is a responsibility for the release manager. π |
||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for the OpenSearch product release and not core vs dashboard