Skip to content

Sanitize error messages to avoid reflecting user input #4315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Sanitize error messages to avoid reflecting user input #4315

wants to merge 4 commits into from

Conversation

iamjag08
Copy link

@iamjag08 iamjag08 commented Oct 14, 2025 •
edited
Loading

Description

This PR addresses a security concern where some API error responses were reflecting user-supplied input in the returned error messages. Reflecting user input in error responses can lead to security issues.

Related Issues

Resolves #[[3990]]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@iamjag08 iamjag08 requested a deployment to ml-commons-cicd-env-require-approval October 14, 2025 14:03 — with GitHub Actions Waiting
@iamjag08 iamjag08 requested a deployment to ml-commons-cicd-env-require-approval October 14, 2025 14:03 — with GitHub Actions Waiting
@iamjag08 iamjag08 requested a deployment to ml-commons-cicd-env-require-approval October 14, 2025 14:03 — with GitHub Actions Waiting
@iamjag08 iamjag08 requested a deployment to ml-commons-cicd-env-require-approval October 14, 2025 14:03 — with GitHub Actions Waiting
@iamjag08 iamjag08 force-pushed the bug-fix/sanitize-error-messages branch from 0a03a0d to a938815 Compare October 14, 2025 14:15
@iamjag08 iamjag08 requested a deployment to ml-commons-cicd-env-require-approval October 14, 2025 14:17 — with GitHub Actions Waiting
@iamjag08 iamjag08 requested a deployment to ml-commons-cicd-env-require-approval October 14, 2025 14:17 — with GitHub Actions Waiting
@iamjag08 iamjag08 requested a deployment to ml-commons-cicd-env-require-approval October 14, 2025 14:17 — with GitHub Actions Waiting
@iamjag08 iamjag08 requested a deployment to ml-commons-cicd-env-require-approval October 14, 2025 14:17 — with GitHub Actions Waiting
@iamjag08 iamjag08 had a problem deploying to ml-commons-cicd-env-require-approval October 14, 2025 14:20 — with GitHub Actions Failure
@iamjag08 iamjag08 had a problem deploying to ml-commons-cicd-env-require-approval October 14, 2025 14:20 — with GitHub Actions Failure
@iamjag08 iamjag08 had a problem deploying to ml-commons-cicd-env-require-approval October 14, 2025 14:20 — with GitHub Actions Error
@iamjag08 iamjag08 had a problem deploying to ml-commons-cicd-env-require-approval October 14, 2025 14:20 — with GitHub Actions Error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@b4sjoo b4sjoo Awaiting requested review from b4sjoo b4sjoo will be requested when the pull request is marked ready for review b4sjoo is a code owner

@dhrubo-os dhrubo-os Awaiting requested review from dhrubo-os dhrubo-os will be requested when the pull request is marked ready for review dhrubo-os is a code owner

@mingshl mingshl Awaiting requested review from mingshl mingshl will be requested when the pull request is marked ready for review mingshl is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es will be requested when the pull request is marked ready for review jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse will be requested when the pull request is marked ready for review model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna will be requested when the pull request is marked ready for review rbhavna is a code owner

@ylwu-amzn ylwu-amzn Awaiting requested review from ylwu-amzn ylwu-amzn will be requested when the pull request is marked ready for review ylwu-amzn is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo will be requested when the pull request is marked ready for review zane-neo is a code owner

@Zhangxunmt Zhangxunmt Awaiting requested review from Zhangxunmt Zhangxunmt will be requested when the pull request is marked ready for review Zhangxunmt is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee will be requested when the pull request is marked ready for review austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 will be requested when the pull request is marked ready for review HenryL27 is a code owner

@sam-herman sam-herman Awaiting requested review from sam-herman sam-herman will be requested when the pull request is marked ready for review sam-herman is a code owner

@xinyual xinyual Awaiting requested review from xinyual xinyual will be requested when the pull request is marked ready for review xinyual is a code owner

@pyek-bot pyek-bot Awaiting requested review from pyek-bot pyek-bot will be requested when the pull request is marked ready for review pyek-bot is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@iamjag08