Fix ISM index parameters to use Indices type instead of IndexName#1098
Open
sean- wants to merge 1 commit intoopensearch-project:mainfrom
Open
Fix ISM index parameters to use Indices type instead of IndexName#1098sean- wants to merge 1 commit intoopensearch-project:mainfrom
sean- wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
The ISM path and query parameters for add_policy, change_policy, explain, remove_policy, retry, and refresh_search_analyzers accept comma-separated index lists and wildcards, but were incorrectly typed as IndexName (scalar string). Change them to reference Indices, which supports both single index names and arrays. This matches the documented behavior and is consistent with how other namespaces (cluster, cat) type their multi-index parameters. Fixes: opensearch-project#1097 Signed-off-by: Sean Chittenden <sean.chittenden@crowdstrike.com>
sean-
requested review from
Tokesh,
VachaShah,
Xtansia,
aabeshov,
harshavamsi,
karenyrx,
lucy66hw and
sachetalva
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ISM path and query parameters for
add_policy,change_policy,explain,remove_policy,retry, andrefresh_search_analyzersaccept comma-separated index lists and wildcards, but were incorrectly typed asIndexName(scalar string). Change them to referenceIndices, which supports both single index names and arrays.This matches the documented behavior and is consistent with how other namespaces (
cluster,cat) type their multi-index parameters.Fixes: #1097
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.