Skip to content

simplify UserAttributes#findUnresolvedAttributes#6122

Merged
cwperks merged 1 commit intoopensearch-project:mainfrom
rursprung:improve-UserAttributes.findUnresolvedAttributes
Apr 30, 2026
Merged

simplify UserAttributes#findUnresolvedAttributes#6122
cwperks merged 1 commit intoopensearch-project:mainfrom
rursprung:improve-UserAttributes.findUnresolvedAttributes

Conversation

@rursprung
Copy link
Copy Markdown
Contributor

Description

no functional change, this just simplifies the code. this is a follow-up to PR #5975

CC @ThyTran1402

Issues Resolved

n/a

Testing

unit test

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rursprung
Copy link
Copy Markdown
Contributor Author

the CI failure seems to be a false reject:

  • What went wrong:
    A problem occurred configuring root project 'opensearch-security'.

java.io.IOException: Failed to load eclipse jdt formatter: java.lang.RuntimeException: java.net.SocketTimeoutException: Connect timed out

@nibix
Copy link
Copy Markdown
Collaborator

nibix commented Apr 28, 2026

the CI failure seems to be a false reject:

re-running the jobs

no functional change, this just simplifies the code.
this is a follow-up to PR opensearch-project#5975

Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com>
@rursprung rursprung force-pushed the improve-UserAttributes.findUnresolvedAttributes branch from 2436e6f to bc44bcd Compare April 28, 2026 17:01
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.79%. Comparing base (ea6087c) to head (bc44bcd).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6122   +/-   ##
=======================================
  Coverage   74.78%   74.79%           
=======================================
  Files         447      447           
  Lines       28467    28465    -2     
  Branches     4328     4329    +1     
=======================================
  Hits        21289    21289           
+ Misses       5184     5183    -1     
+ Partials     1994     1993    -1     
Files with missing lines Coverage Δ
...opensearch/security/privileges/UserAttributes.java 82.14% <100.00%> (-2.24%) ⬇️

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rursprung
Copy link
Copy Markdown
Contributor Author

not sure why code coverage went down - i deleted code, so the coverage should go up if it stupidly counts lines (if it counts invocations it should be the same). either way, i think the CI failure is a false-positive

@cwperks
Copy link
Copy Markdown
Member

cwperks commented Apr 29, 2026

not sure why code coverage went down - i deleted code, so the coverage should go up if it stupidly counts lines (if it counts invocations it should be the same). either way, i think the CI failure is a false-positive

There's some randomization in the testing so -0.02% coverage can come up for a small change like this. Its not a blocking check, but helps give a maintainer insight into patch coverage for a PR.

@cwperks cwperks merged commit 244fd05 into opensearch-project:main Apr 30, 2026
159 of 163 checks passed
@rursprung rursprung deleted the improve-UserAttributes.findUnresolvedAttributes branch April 30, 2026 14:11
terryquigleysas pushed a commit to terryquigleysas/security that referenced this pull request May 1, 2026
…t#6122)

Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com>
Signed-off-by: Terry Quigley <terry.quigley@sas.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants