simplify UserAttributes#findUnresolvedAttributes#6122
Conversation
|
the CI failure seems to be a false reject:
|
re-running the jobs |
no functional change, this just simplifies the code. this is a follow-up to PR opensearch-project#5975 Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com>
2436e6f to
bc44bcd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6122 +/- ##
=======================================
Coverage 74.78% 74.79%
=======================================
Files 447 447
Lines 28467 28465 -2
Branches 4328 4329 +1
=======================================
Hits 21289 21289
+ Misses 5184 5183 -1
+ Partials 1994 1993 -1
🚀 New features to boost your workflow:
|
|
not sure why code coverage went down - i deleted code, so the coverage should go up if it stupidly counts lines (if it counts invocations it should be the same). either way, i think the CI failure is a false-positive |
There's some randomization in the testing so -0.02% coverage can come up for a small change like this. Its not a blocking check, but helps give a maintainer insight into patch coverage for a PR. |
…t#6122) Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com> Signed-off-by: Terry Quigley <terry.quigley@sas.com>
Description
no functional change, this just simplifies the code. this is a follow-up to PR #5975
CC @ThyTran1402
Issues Resolved
n/a
Testing
unit test
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.