Skip to content

Wait 45s before health check to resolve Windows plugin install flakiness#6125

Merged
finnegancarroll merged 1 commit intoopensearch-project:mainfrom
cwperks:flaky-fixes
Apr 30, 2026
Merged

Wait 45s before health check to resolve Windows plugin install flakiness#6125
finnegancarroll merged 1 commit intoopensearch-project:mainfrom
cwperks:flaky-fixes

Conversation

@cwperks
Copy link
Copy Markdown
Member

@cwperks cwperks commented Apr 30, 2026

Description

This GHA just released v10 that includes the following 2 changes:

  • Category

Maintenance

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

PR Code Analyzer ❗

AI-powered 'Code-Diff-Analyzer' found issues on commit e57c25a.

PathLineSeverityDescription
.github/workflows/plugin_install.yml48highThird-party GitHub Action 'derek-ho/start-opensearch' upgraded from @v9 to @v10. Mutable version tags in GitHub Actions can be redirected to arbitrary commits at any time, and the new tag may introduce malicious code with access to CI secrets and the runner environment. Maintainers must verify the contents of v10 and consider pinning to an immutable commit SHA instead.

The table above displays the top 10 most important findings.

Total: 1 | Critical: 0 | High: 1 | Medium: 0 | Low: 0


Pull Requests Author(s): Please update your Pull Request according to the report above.

Repository Maintainer(s): You can bypass diff analyzer by adding label skip-diff-analyzer after reviewing the changes carefully, then re-run failed actions. To re-enable the analyzer, remove the label, then re-run all actions.


⚠️ Note: The Code-Diff-Analyzer helps protect against potentially harmful code patterns. Please ensure you have thoroughly reviewed the changes beforehand.

Thanks.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.75%. Comparing base (ea6087c) to head (e57c25a).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6125      +/-   ##
==========================================
- Coverage   74.78%   74.75%   -0.03%     
==========================================
  Files         447      447              
  Lines       28467    28463       -4     
  Branches     4328     4328              
==========================================
- Hits        21289    21278      -11     
- Misses       5184     5189       +5     
- Partials     1994     1996       +2     

see 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cwperks cwperks added the skip-diff-analyzer Maintainer to skip code-diff-analyzer check, after reviewing issues in AI analysis. label Apr 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ Recommended focus areas for review

Version Bump

The action derek-ho/start-opensearch is being bumped from v9 to v10. It is worth verifying that the changes introduced in v10 (the 45s health check wait and any other changes) are compatible with the existing workflow configuration and do not introduce unexpected behavior or breaking changes.

  uses: derek-ho/start-opensearch@v10
  if: ${{ runner.os != 'Windows' }}
  with:
    opensearch-version: ${{ env.OPENSEARCH_VERSION }}
    plugins: "file:$(pwd)/${{ env.PLUGIN_NAME }}.zip"
    security-enabled: true
    admin-password: ${{ steps.generate-password.outputs.password }}
    jdk-version: 21

- name: Run Opensearch with A Single Plugin
  uses: derek-ho/start-opensearch@v10

@finnegancarroll finnegancarroll merged commit b803a54 into opensearch-project:main Apr 30, 2026
68 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-diff-analyzer Maintainer to skip code-diff-analyzer check, after reviewing issues in AI analysis.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants