Update to dynamic-plugin-sdk@0.0.3 and webpack@5.63.0#61
Open
jtomasek wants to merge 2 commits intoopenshift-assisted:mainfrom
Open
Update to dynamic-plugin-sdk@0.0.3 and webpack@5.63.0#61jtomasek wants to merge 2 commits intoopenshift-assisted:mainfrom
jtomasek wants to merge 2 commits intoopenshift-assisted:mainfrom
Conversation
rawagner
approved these changes
Nov 10, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jtomasek, rawagner The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
added 2 commits
November 15, 2021 14:39
Replacing K8sResourceCommon type with CR specific ones Importing types from 'openshift-assisted-ui-lib/dist/src/cim/types' instead of using them from CIM variable
jtomasek
force-pushed
the
update-webpack
branch
from
47cace2 to
d307b4b
Compare
jtomasek
commented
Nov 16, 2021
Comment on lines
+51
to
+52
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | ||
| data: getClusterDeploymentForInfraEnv(secret.metadata?.name!, namespace, values), |
Author
There was a problem hiding this comment.
It is unfortunate that K8sResourceCommon defines all metadata as optional. It would be good to enhance it to reflect the reality and make the required metadata properties such as name and namespace required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on openshift-assisted/assisted-installer-ui#954