Skip to content

Conversation

@vfreex
Copy link
Contributor

@vfreex vfreex commented Jan 19, 2026

The build-sync pipeline was not respecting the --data-path parameter when determining supported architectures. The branch_arches() function would always use the default ocp-build-data repository instead of the custom fork/branch specified by the user.

This fix:

  • Adds data_path and doozer_data_gitref parameters to branch_arches()
  • Updates build_sync.py to pass these parameters
  • Updates build_sync_multi.py to pass these parameters
  • Ensures configuration consistency throughout the pipeline

The fix is backwards compatible with default parameter values.

The build-sync pipeline was not respecting the --data-path parameter
when determining supported architectures. The branch_arches() function
would always use the default ocp-build-data repository instead of the
custom fork/branch specified by the user.

This fix:
- Adds data_path and doozer_data_gitref parameters to branch_arches()
- Updates build_sync.py to pass these parameters
- Updates build_sync_multi.py to pass these parameters
- Ensures configuration consistency throughout the pipeline

The fix is backwards compatible with default parameter values.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign adobes1 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 19, 2026

Walkthrough

This change adds two new parameters (data_path and doozer_data_gitref) to the branch_arches function to propagate pipeline data context. The function signature is extended with default values, and calling sites in two pipeline files pass these parameters during invocation.

Changes

Cohort / File(s) Summary
Pipeline Updates
pyartcd/pyartcd/pipelines/build_sync.py, pyartcd/pyartcd/pipelines/build_sync_multi.py
Added data_path and doozer_data_gitref keyword arguments to branch_arches calls in pipeline run() methods (+2/-0 each)
Function Signature Extension
pyartcd/pyartcd/util.py
Extended branch_arches function signature to accept data_path and doozer_data_gitref parameters with defaults; updated internal load_group_config call to pass these values; added corresponding docstring entries (+15/-2)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2026

@vfreex: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security fed5e9f link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant