Ensure we do a string check of the is_rename value#492
Merged
komish merged 1 commit intoopenshift-helm-charts:mainfrom Feb 3, 2026
Merged
Ensure we do a string check of the is_rename value#492komish merged 1 commit intoopenshift-helm-charts:mainfrom
komish merged 1 commit intoopenshift-helm-charts:mainfrom
Conversation
acornett21
approved these changes
Feb 3, 2026
komish
force-pushed
the
fixup-ensure-string-check
branch
from
2bce8c7 to
487f378
Compare
Signed-off-by: Jose R. Gonzalez <komish@flutes.dev>
komish
force-pushed
the
fixup-ensure-string-check
branch
from
487f378 to
30cf1ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We set a boolean to this output, but we need to check the stringified value, as that's what we actually see in the conditional expression.
Also removed an irrelevant log line.