fix(deploy): use JSON list format for CORS origins in stage#448
fix(deploy): use JSON list format for CORS origins in stage#448
Conversation
Pydantic-settings requires JSON list format for list[str] fields. Comma-separated strings fail to parse, causing CORS middleware to not initialize and OPTIONS preflight requests to return 405. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughA Kubernetes ConfigMap resource in the staging environment overlay is updated to modify the CORS origins configuration for the Kartograph service. The Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
KARTOGRAPH_CORS_ORIGINSis alist[str]field in pydantic-settings, which requires JSON list format. The comma-separated string was failing to parse, so CORS middleware never initialized — causing 405 on OPTIONS preflight requests.Verified locally: comma-separated → parse error, JSON list → works.
🤖 Generated with Claude Code
Summary by CodeRabbit