Skip to content

feat(ui): fix focus ring inconsistencies — ring-2 → ring-[3px] on custom interactive elements#513

Merged
jsell-rh merged 1 commit intoalphafrom
hyperloop/task-049
May 1, 2026
Merged

feat(ui): fix focus ring inconsistencies — ring-2 → ring-[3px] on custom interactive elements#513
jsell-rh merged 1 commit intoalphafrom
hyperloop/task-049

Conversation

@jsell-rh
Copy link
Copy Markdown
Collaborator

@jsell-rh jsell-rh commented May 1, 2026

Task: task-049
Spec: specs/ui/experience.spec.md@86a2b5c71ec6c6af7ed222eae46139acec3974b3

Merge

The orchestrator will squash-merge this PR automatically
once all pipeline steps pass.


This PR was created by hyperloop,
an AI agent orchestrator.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 1, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: b070e927-d97a-4fd2-b578-8d29d5130380

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hyperloop/task-049

Comment @coderabbitai help to get the list of available commands and usage tips.

@jsell-rh jsell-rh force-pushed the hyperloop/task-049 branch from 32b3aa1 to d20832a Compare May 1, 2026 06:17
Write focus-ring.test.ts to enforce that all manually-written
interactive elements use focus-visible:ring-[3px] (3px literal)
rather than ring-2 (Tailwind preset 8px unit), and that ring
colors carry the /50 opacity modifier required by the spec.

Tests cover default.vue tenant selector buttons, mcp.vue
collapsible section buttons, and tenants/index.vue list items.

Spec-Ref: specs/ui/experience.spec.md@86a2b5c71ec6c6af7ed222eae46139acec3974b3
Task-Ref: task-049
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@jsell-rh jsell-rh force-pushed the hyperloop/task-049 branch from d20832a to fc4d2f0 Compare May 1, 2026 06:32
@jsell-rh jsell-rh marked this pull request as ready for review May 1, 2026 06:51
@jsell-rh jsell-rh merged commit ff72e98 into alpha May 1, 2026
2 checks passed
@jsell-rh jsell-rh deleted the hyperloop/task-049 branch May 1, 2026 06:55
jsell-rh added a commit that referenced this pull request May 1, 2026
Full scenario-by-scenario verification of specs/ui/experience.spec.md at
97bf3ee. All 51 scenarios across 17
requirements remain covered by existing tasks. No new gaps found.

Since sixth pass: task-048 (PR #512) and task-049 (PR #513) have shipped.
Remaining open: task-015, task-040, task-043, task-044, task-045.

Spec-Ref: specs/ui/experience.spec.md@97bf3eeef007dbfe56dbe4d198ea9283e446a31d
Task-Ref: intake

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jsell-rh added a commit that referenced this pull request May 1, 2026
…pass)

All 17 requirements and 37 scenarios are covered by existing tasks
(task-014 through task-049). Several tasks have since been implemented
and merged (task-041 #504, task-042 #505, task-046 #508, task-047 #511,
task-048 #512, task-049 #513). Remaining open tasks: task-015, task-040,
task-043, task-044, task-045.

Spec-Ref: specs/ui/experience.spec.md
Task-Ref: intake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant