Skip to content

Comments

CNFCERT-1258: Add kustomize validation check#969

Open
sebrandon1 wants to merge 1 commit intoopenshift-kni:masterfrom
sebrandon1:add_kustomization_test
Open

CNFCERT-1258: Add kustomize validation check#969
sebrandon1 wants to merge 1 commit intoopenshift-kni:masterfrom
sebrandon1:add_kustomization_test

Conversation

@sebrandon1
Copy link

Similar to: openshift-kni/telco-reference#433

Changes:

  • Adds a quick PR check that attempts to kustomize build appropriate files. Only runs against master.
  • Adds a make path for make test-kustomize which runs the script. Users can run this locally as well as there are safeguards to ensure kustomize exists first.
  • Skips YAMLs that might require external plugins. See EXCLUDED_DIRS.

Example run:

$ make test-kustomize
hack/test-kustomize.sh
Checking all kustomization.yaml files can build successfully...

  ./cluster-setup/base/performance: OK
  ./cluster-setup/ci-cluster/performance: OK
  ./cluster-setup/ci-upgrade-test-cluster/performance: OK
  ./cluster-setup/manual-cluster/performance: OK
  ./cluster-setup/mcp-only-cluster/performance: OK
  ./cluster-setup/upgrade-test-cluster/performance: OK
  ./config/crd: OK
  ./config/default: OK
  ./config/manager: OK
  ./config/rbac: OK
  ./config/samples: OK

Summary: Checked 11 kustomization.yaml files, skipped 0 (require external plugins)
All kustomization files validated successfully!

@openshift-ci openshift-ci bot requested review from fedepaol and ffromani October 30, 2025 20:18
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please assign schseba for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sebrandon1
Copy link
Author

@sebrandon1 sebrandon1 changed the title Add kustomize validation check CNFCERT-1258: Add kustomize validation check Jan 16, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 16, 2026
@openshift-ci-robot
Copy link
Collaborator

@sebrandon1: This pull request references CNFCERT-1258 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Similar to: openshift-kni/telco-reference#433

Changes:

  • Adds a quick PR check that attempts to kustomize build appropriate files. Only runs against master.
  • Adds a make path for make test-kustomize which runs the script. Users can run this locally as well as there are safeguards to ensure kustomize exists first.
  • Skips YAMLs that might require external plugins. See EXCLUDED_DIRS.

Example run:

$ make test-kustomize
hack/test-kustomize.sh
Checking all kustomization.yaml files can build successfully...

 ./cluster-setup/base/performance: OK
 ./cluster-setup/ci-cluster/performance: OK
 ./cluster-setup/ci-upgrade-test-cluster/performance: OK
 ./cluster-setup/manual-cluster/performance: OK
 ./cluster-setup/mcp-only-cluster/performance: OK
 ./cluster-setup/upgrade-test-cluster/performance: OK
 ./config/crd: OK
 ./config/default: OK
 ./config/manager: OK
 ./config/rbac: OK
 ./config/samples: OK

Summary: Checked 11 kustomization.yaml files, skipped 0 (require external plugins)
All kustomization files validated successfully!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sebrandon1
Copy link
Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants