Clustercompare v4.19.0 accusing a diff in the sctp ignition version#254
Clustercompare v4.19.0 accusing a diff in the sctp ignition version#254sferlin wants to merge 1 commit intoopenshift-kni:release-4.18from
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sferlin The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @sferlin. Thanks for your PR. I'm waiting for a openshift-kni member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
imiller0
left a comment
There was a problem hiding this comment.
There are a couple other minor differences in this version of the CR from the one in configuration/optional/other. Can you reconcile so that they are the same. Thanks!
|
/ok-to-test |
| config: | ||
| ignition: | ||
| version: 2.2.0 | ||
| version: 3.2.0 |
There was a problem hiding this comment.
There are also slight differences in the content in ../../../configuration/reference-crs/optional/other/sctp_module_mc.yaml. Can you update so that the configuration version matches this one please
|
Hmmm... This seems to be hinting at a deeper issue here... While we do have CI that makes sure our cluster-compare templates don't diverge too far from the reference CRs, these install/extra-manifests are exempt from the checking, so they can diverge like this... I think we need to consider closing that gap as well. |
Output from cluster-compare (v4.19.0) (below) differing from the reference here:
CC: @lack @imiller0