Skip to content

Comments

Clustercompare v4.19.0 accusing a diff in the sctp ignition version#254

Open
sferlin wants to merge 1 commit intoopenshift-kni:release-4.18from
sferlin:clustercompare
Open

Clustercompare v4.19.0 accusing a diff in the sctp ignition version#254
sferlin wants to merge 1 commit intoopenshift-kni:release-4.18from
sferlin:clustercompare

Conversation

@sferlin
Copy link

@sferlin sferlin commented Jul 3, 2025

Output from cluster-compare (v4.19.0) (below) differing from the reference here:

[](Cluster CR: machineconfiguration.openshift.io/v1_MachineConfig_load-sctp-module
Reference File: optional/other/sctp_module_mc.yaml
Description:
  https://docs.openshift.com/container-platform/4.17/scalability_and_performance/telco_ref_design_specs/core/telco-core-ref-crs.html#node-configuration-crs_ran-core-ref-design-crs
Diff Output: diff -u -N /tmp/MERGED-675760767/machineconfiguration-openshift-io-v1_machineconfig_load-sctp-module /tmp/LIVE-38140128/machineconfiguration-openshift-io-v1_machineconfig_load-sctp-module
--- /tmp/MERGED-675760767/machineconfiguration-openshift-io-v1_machineconfig_load-sctp-module	2025-07-02 07:49:01.583315484 +0000
+++ /tmp/LIVE-38140128/machineconfiguration-openshift-io-v1_machineconfig_load-sctp-module	2025-07-02 07:49:01.583315484 +0000
@@ -7,16 +7,16 @@
 spec:
   config:
     ignition:
-      version: 3.2.0
+      version: 2.2.0
     storage:
       files:
       - contents:
           source: data:,
+          verification: {}
+        filesystem: root
         mode: 420
-        overwrite: true
         path: /etc/modprobe.d/sctp-blacklist.conf
       - contents:
           source: data:,sctp
         mode: 420
-        overwrite: true
         path: /etc/modules-load.d/sctp-load.conf)

CC: @lack @imiller0

@openshift-ci openshift-ci bot requested review from cgoncalves and yuvalk July 3, 2025 09:17
@openshift-ci
Copy link

openshift-ci bot commented Jul 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sferlin
Once this PR has been reviewed and has the lgtm label, please assign imiller0 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Jul 3, 2025

Hi @sferlin. Thanks for your PR.

I'm waiting for a openshift-kni member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 3, 2025
Copy link
Collaborator

@imiller0 imiller0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple other minor differences in this version of the CR from the one in configuration/optional/other. Can you reconcile so that they are the same. Thanks!

@imiller0
Copy link
Collaborator

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 16, 2025
config:
ignition:
version: 2.2.0
version: 3.2.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also slight differences in the content in ../../../configuration/reference-crs/optional/other/sctp_module_mc.yaml. Can you update so that the configuration version matches this one please

@lack
Copy link
Member

lack commented Oct 8, 2025

Hmmm... This seems to be hinting at a deeper issue here... While we do have CI that makes sure our cluster-compare templates don't diverge too far from the reference CRs, these install/extra-manifests are exempt from the checking, so they can diverge like this... I think we need to consider closing that gap as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants