Skip to content

Comments

telco-hub: cluster-compare: ignore several annotations/labels and CR names#366

Open
borball wants to merge 1 commit intoopenshift-kni:mainfrom
borball:main
Open

telco-hub: cluster-compare: ignore several annotations/labels and CR names#366
borball wants to merge 1 commit intoopenshift-kni:mainfrom
borball:main

Conversation

@borball
Copy link

@borball borball commented Sep 24, 2025

In telco-hub cluster compare tool, ignore several annotations and labels, also don't compare the CR names for operatorgroup and subscription.

@openshift-ci
Copy link

openshift-ci bot commented Sep 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: borball
Once this PR has been reviewed and has the lgtm label, please assign irinamihai for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 24, 2025
@openshift-ci
Copy link

openshift-ci bot commented Sep 24, 2025

Hi @borball. Thanks for your PR.

I'm waiting for a openshift-kni member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

annotations:
argocd.argoproj.io/sync-wave: "-40"
name: odf-operator
name: {{ .metadata.name }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has a side-effect of matching this Subscription CR to all the sub-operator subscriptions that ODF creates when it is installed. Those then show various differences that aren't relevant since they are owned by ODF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants