OCPBUGS-62684: Move enable-crun manifests out of optional manifests#531
OCPBUGS-62684: Move enable-crun manifests out of optional manifests#531sudomakeinstall2 wants to merge 1 commit intoopenshift-kni:mainfrom
Conversation
|
@sudomakeinstall2: This pull request references Jira Issue OCPBUGS-6284, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sudomakeinstall2 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@sudomakeinstall2: This pull request references Jira Issue OCPBUGS-62684, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
fd64988 to
5b1064a
Compare
According to RDS enable-crun is not optional. This commit moves them out of the optional folder. Signed-off-by: Saeid Askari <saskari@redhat.com>
|
/lgtm |
telco-ran/configuration/Makefile
Outdated
| case "$${sourcefile}" in \ | ||
| */extra-manifest/* | \ | ||
| */optional-extra-manifest/* | \ | ||
| */crun/* | \ |
There was a problem hiding this comment.
Why not move the crun extra-manifests under the extra-manifest directory OR rename crun to extra-manifest-crun to make the purpose obvious?
There was a problem hiding this comment.
Makes sense. Thanks Irina.
5b1064a to
2ddd48e
Compare
|
New changes are detected. LGTM label has been removed. |
According to RDS enable-crun is not optional. This commit moves them out
of the optional folder.
Signed-off-by: Saeid Askari saskari@redhat.com