Skip to content

Comments

OCPBUGS-62684: Move enable-crun manifests out of optional manifests#531

Open
sudomakeinstall2 wants to merge 1 commit intoopenshift-kni:mainfrom
sudomakeinstall2:main
Open

OCPBUGS-62684: Move enable-crun manifests out of optional manifests#531
sudomakeinstall2 wants to merge 1 commit intoopenshift-kni:mainfrom
sudomakeinstall2:main

Conversation

@sudomakeinstall2
Copy link
Contributor

According to RDS enable-crun is not optional. This commit moves them out
of the optional folder.

Signed-off-by: Saeid Askari saskari@redhat.com

@openshift-ci openshift-ci bot requested a review from irinamihai January 15, 2026 16:29
@openshift-ci-robot
Copy link
Collaborator

@sudomakeinstall2: This pull request references Jira Issue OCPBUGS-6284, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the vulnerability to target either version "4.22." or "openshift-4.22.", but it targets "4.13.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Not a Bug) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

According to RDS enable-crun is not optional. This commit moves them out
of the optional folder.

Signed-off-by: Saeid Askari saskari@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Jan 15, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sudomakeinstall2
Once this PR has been reviewed and has the lgtm label, please assign imiller0 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested a review from SchSeba January 15, 2026 16:29
@sudomakeinstall2 sudomakeinstall2 changed the title OCPBUGS-6284: Move enable-crun manifests out of optional manifests OCPBUGS-62684: Move enable-crun manifests out of optional manifests Jan 15, 2026
@openshift-ci-robot
Copy link
Collaborator

@sudomakeinstall2: This pull request references Jira Issue OCPBUGS-62684, which is invalid:

  • expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "4.21.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

According to RDS enable-crun is not optional. This commit moves them out
of the optional folder.

Signed-off-by: Saeid Askari saskari@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

According to RDS enable-crun is not optional. This commit moves them out
of the optional folder.

Signed-off-by: Saeid Askari <saskari@redhat.com>
@abraham2512
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2026
case "$${sourcefile}" in \
*/extra-manifest/* | \
*/optional-extra-manifest/* | \
*/crun/* | \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not move the crun extra-manifests under the extra-manifest directory OR rename crun to extra-manifest-crun to make the purpose obvious?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks Irina.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 17, 2026

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants