Added dynamic secret name resolution for hub's altermanager#566
Added dynamic secret name resolution for hub's altermanager#566mvazquezc wants to merge 1 commit intoopenshift-kni:release-4.20from
Conversation
Signed-off-by: Mario Vazquez <mavazque@redhat.com>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mvazquezc The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @mvazquezc. Thanks for your PR. I'm waiting for a openshift-kni member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @mvazquezc, thanks for the PR. Could you target this to main branch? This should be backported to 4.21,4.20 |
| bearerToken: | ||
| key: token | ||
| name: observability-alertmanager-accessor | ||
| name: {{ if (lookup "v1" "Namespace" "" "open-cluster-management-addon-observability") }}{{ (regexFind "hub-cluster-id(.*)" ((fromSecret "open-cluster-management-addon-observability" "hub-info-secret" "hub-info.yaml") | base64dec)) | replace "hub-cluster-id: " "observability-alertmanager-accessor-" }}{{ end }} |
There was a problem hiding this comment.
What does this look like on ACM 2.14 and ACM 2.15? Is this hub secret information available on both versions?
|
Closing in favour of #567 |
2 participants
This change aims to fix an issue where prometheus pod won't start due to wrongly referenced secrets.