Skip to content

Comments

OCPBUGS-72511: Explicitly set the name of BSL#568

Open
sudomakeinstall2 wants to merge 1 commit intoopenshift-kni:mainfrom
sudomakeinstall2:OCPBUGS-72511
Open

OCPBUGS-72511: Explicitly set the name of BSL#568
sudomakeinstall2 wants to merge 1 commit intoopenshift-kni:mainfrom
sudomakeinstall2:OCPBUGS-72511

Conversation

@sudomakeinstall2
Copy link
Contributor

This commit explicitly sets the name of backupstoragelocation in DataProtectionApplication, and no longer rely only on the default behaviour.
Also we make sure the backupstoragelocation status policy has a bigger ztp wave annotation number. This is because the status policy creates an empty backupstoragelocation, and with recent changes in oadp we are not allowed to set the default value for a backupstoragelocation after it has been already created.

This commit explicitly sets the name of backupstoragelocation in
DataProtectionApplication, and no longer rely only on the default
behaviour.
Also we make sure the backupstoragelocation status policy has
a bigger ztp wave annotation number. This is because the status policy
creates an empty backupstoragelocation, and with recent changes in oadp
we are not allowed to set the default value for a backupstoragelocation
after it has been already created.

Signed-off-by: Saeid Askari <saskari@redhat.com>
@openshift-ci openshift-ci bot requested review from fedepaol and sabbir-47 January 28, 2026 17:21
@openshift-ci-robot
Copy link
Collaborator

@sudomakeinstall2: This pull request references Jira Issue OCPBUGS-72511, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This commit explicitly sets the name of backupstoragelocation in DataProtectionApplication, and no longer rely only on the default behaviour.
Also we make sure the backupstoragelocation status policy has a bigger ztp wave annotation number. This is because the status policy creates an empty backupstoragelocation, and with recent changes in oadp we are not allowed to set the default value for a backupstoragelocation after it has been already created.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sudomakeinstall2
Once this PR has been reviewed and has the lgtm label, please assign lack for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sudomakeinstall2
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants