AGENT-1207: automate OVE cluster installation #1796
Conversation
|
/cc @andfasano |
andfasano
left a comment
andfasano
left a comment
There was a problem hiding this comment.
Thanks @pawanpinjarkar for the update, it's definitely an improvement and the number of vendored files has been reduced. The post validation part still needs some additional tweaks.
This version looks good for having a better CI job, but once consolidated though, I'd prefer to find a way to remove such all golang files from this repo, so I'd advise to schedule a card for such task
| exit 0 | ||
| oc wait clusterversion version --for=condition=Available=True --timeout=60m | ||
| oc get csv -A | ||
| oc get packagemanifests -n openshift-marketplace |
There was a problem hiding this comment.
What are these two commands for? It doesn't seem they are testing anything. I was expecting a more explicit check on the list of installed operators
There was a problem hiding this comment.
oc get csv -A is not useful seems like. oc get packagemanifests -n openshift-marketplace gives a list of operators , e.g.
oc get packagemanifests -n openshift-marketplace
Member
NAME CATALOG AGE
kubernetes-nmstate-operator 3d20h
kubevirt-hyperconverged 3d20h
node-healthcheck-operator 3d20h
fence-agents-remediation 3d20h
mtv-operator 3d20h
cluster-kube-descheduler-operator 3d20h
node-maintenance-operator 3d20h
There was a problem hiding this comment.
What are these two commands for? It doesn't seem they are testing anything. I was expecting a more explicit check on the list of installed operators
Could you suggest what else we should be testing?
There was a problem hiding this comment.
@andfasano Created this task https://issues.redhat.com/browse/AGENT-1304
There was a problem hiding this comment.
Could you suggest what else we should be testing?
Sorry missed that comment. This part must be changed to verify that the expected list of OLM operators have been successfully installed.
Specifically, the script must check that for each operator listed here (the list can be hard-coded, since it's not going to change so often)
| exit 1 | ||
| fi | ||
|
|
||
| oc get clusterversion |
There was a problem hiding this comment.
I thought this to be a good way to see the cluster version
e.g. oc get clusterversion NAME VERSION AVAILABLE PROGRESSING SINCE STATUS version 4.19.7 True False 3d19h Error while reconciling 4.19.7: the cluster operator insights is not available
There was a problem hiding this comment.
I think it would be preferable, for each required OLM operator, to explicitly verify if it was installed or not, and report it.
agent/06_agent_create_cluster.sh
Outdated
| rendezvousIP=$(getRendezvousIP) | ||
| get_vips | ||
| # Simulate user actions as done on the webUI and start cluster installation | ||
| RENDEZVOUS_IP=$rendezvousIP OCP_DIR=$OCP_DIR INGRESS_VIP=$INGRESS_VIPS API_VIP=$API_VIPS go run -mod vendor agent/isobuilder/ui_driven_cluster_installation.go |
There was a problem hiding this comment.
Not a blocking point, but wouldn't it have been simpler to pass them as a regular args?
|
@pawanpinjarkar it looks like the |
|
/retest e2e-agent-iso-no-registry-compact-ipv4 |
|
@pawanpinjarkar: The The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The job is not passing from past few days. Will take a look. Thanks. |
|
/test e2e-agent-iso-no-registry-compact-ipv4 |
1 similar comment
|
/test e2e-agent-iso-no-registry-compact-ipv4 |
|
The assisted UI does not come up while this is not the same behaviour locally. |
|
/test e2e-agent-iso-no-registry-compact-ipv4 |
5 similar comments
|
/test e2e-agent-iso-no-registry-compact-ipv4 |
|
/test e2e-agent-iso-no-registry-compact-ipv4 |
|
/test e2e-agent-iso-no-registry-compact-ipv4 |
|
/test e2e-agent-iso-no-registry-compact-ipv4 |
|
/test e2e-agent-iso-no-registry-compact-ipv4 |
pawanpinjarkar
force-pushed
the
automate-ove-cluster-installation
branch
from
16d6693 to
a99c2a3
Compare
|
/test e2e-agent-iso-no-registry-compact-ipv4 |
|
Looks like a temp glitch. All jobs failed. |
|
/test e2e-agent-iso-no-registry-compact-ipv4 |
2 similar comments
|
/test e2e-agent-iso-no-registry-compact-ipv4 |
|
/test e2e-agent-iso-no-registry-compact-ipv4 |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
pawanpinjarkar
force-pushed
the
automate-ove-cluster-installation
branch
from
f687a9f to
7a2a91e
Compare
pawanpinjarkar
force-pushed
the
automate-ove-cluster-installation
branch
from
da91fe5 to
917b633
Compare
|
@rwsu PTAL |
pawanpinjarkar
force-pushed
the
automate-ove-cluster-installation
branch
from
917b633 to
9237fc4
Compare
pawanpinjarkar
force-pushed
the
automate-ove-cluster-installation
branch
from
9237fc4 to
8b56ec0
Compare
|
/retest-required |
Automates OVE cluster installation using the Go-based library `go-rod` in headless mode. The workflow fills in cluster details, captures screenshots for each step, downloads credentials, and triggers the install action without requiring a visible browser. Verification steps include: - Confirming cluster installation completion - Running `oc get nodes`, `oc get clusterversion`, `oc get packagemanifests` and `oc wait clusterversion version --for=condition=Available=True --timeout=60m` - Ensuring the number of nodes matches values defined in dev-scripts
pawanpinjarkar
force-pushed
the
automate-ove-cluster-installation
branch
from
8b56ec0 to
f7d0c78
Compare
|
/test e2e-agent-iso-no-registry-compact-ipv4 |
|
@pawanpinjarkar: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-agent-compact-ipv4-iso-no-registry |
|
/test e2e-agent-compact-ipv4-iso-no-registry |
|
/test e2e-agent-compact-ipv4-iso-no-registry |
|
job failed previously because process did not finish before 2h0m0s timeout |
|
/retest-required |
|
/test e2e-agent-compact-ipv4-iso-no-registry |
|
Tested this in dev-scripts and it appeared to work. LGTM from me, although seems to some unresolved comments above. |
|
/test e2e-agent-compact-ipv4-iso-no-registry |
rwsu
left a comment
rwsu
left a comment
There was a problem hiding this comment.
I've been able to reliably install the cluster locally.
/approve
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rwsu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-agent-compact-ipv4-iso-no-registry |
2 similar comments
|
/test e2e-agent-compact-ipv4-iso-no-registry |
|
/test e2e-agent-compact-ipv4-iso-no-registry |
|
@pawanpinjarkar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5 participants
Automates OVE cluster installation using the Go-based library
go-rodin headless mode. The workflow fills in cluster details, captures screenshots for each step, downloads credentials, and triggers the install action without requiring a visible browser.Verification steps include:
oc get nodes,oc get clusterversion,oc get packagemanifestsandoc wait clusterversion version --for=condition=Available=True --timeout=60mSet
Then run
make agent