Skip to content

Fix PR review workflow source for fork PRs#6

Merged
tiwillia merged 1 commit intoopenshift-online:mainfrom
tiwillia:fix/pr-review-workflow-source
Mar 31, 2026
Merged

Fix PR review workflow source for fork PRs#6
tiwillia merged 1 commit intoopenshift-online:mainfrom
tiwillia:fix/pr-review-workflow-source

Conversation

@tiwillia
Copy link
Copy Markdown
Contributor

Summary

  • Hardcode the ambient workflow source to main on openshift-online/open-dispatch instead of using the PR's head branch
  • Fork PRs have their branch on the fork repo, so ACP can't resolve the workflow files when pointed at upstream + fork branch
  • The review skill fetches the PR diff dynamically via gh pr diff, so it doesn't need the PR branch for the workflow source

Test plan

  • Merge this, then verify the test PR (Test Automated PR Review #5) workflow re-triggers or manually re-run it
  • Confirm the ACP session loads the workflow and runs the review

Fork PRs have their head branch on the fork repo, not upstream, so
ACP cannot find the workflow files. Hardcode the workflow source to
main on openshift-online/open-dispatch — the review skill fetches
the PR diff dynamically so it doesn't need the PR branch.
@tiwillia tiwillia merged commit 32c80be into openshift-online:main Mar 31, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant