-
Notifications
You must be signed in to change notification settings - Fork 25
[feat] SRVKP-8326: added step url navigation in pipeline run log tab #660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[feat] SRVKP-8326: added step url navigation in pipeline run log tab #660
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: anwesha-palit-redhat The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
46c1fa2
to
13335ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it is only working for first task of the PLR. If I pass the other taskName apart from first one then it does not work.
PLR-log-step-highlighter.mov
new RegExp(`(${searchTerm})`, 'gi'), | ||
'\x1b[48;2;253;240;171m\x1b[38;2;21;21;21m$1\x1b[0m', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a couple of lines of comments here for easy to understand what the regex does?
@anwesha-palit-redhat: This pull request references SRVKP-8326 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Out of Scope
pac
or other tools to generate these new deep-link URLs. It only covers the console's ability to interpret them.Approach (Required)
The proposed approach is to use a URL query parameter to specify the target step.
Define a URL convention to include the step name.
Update routing logic in the OpenShift Console front-end for the PipelineRun and TaskRun details pages to parse the
step
query parameter.On page load, if the
step
parameter is present in the URL:Dependencies
Acceptance Criteria (Mandatory)
PipelineRun with valid step
?step=<existing-step-name>
,TaskRun with valid step
?step=<existing-step-name>
,Invalid step name
&step=non-existent-step
),Manual interaction
Screen Recording
Untitled.mov