-
Notifications
You must be signed in to change notification settings - Fork 114
chore: Update Jira AI token secret names #2241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update Jira AI token secret names #2241
Conversation
* Update the secret name and key to what we had setup from .tekton/pr-labeler.yaml pipelinerun. * Updated `AI_TOKEN_SECRET` to `gemini-api-key`. * Updated `AI_TOKEN_SECRET_KEY` to `api-key`. Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the Jira AI token secret configuration to match the actual secret names configured in the Tekton pipeline environment.
- Updates AI token secret name from "gemini" to "gemini-api-key"
- Updates AI token secret key from "secret" to "api-key"
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @chmouel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves an inconsistency in the naming of AI token secrets within the Jira integration configuration. The updates ensure that the secret names and keys used in the .tekton/jira.yaml file are aligned with the established values, promoting better configuration management and operational reliability.
Highlights
- AI Token Secret Name Update: The AI_TOKEN_SECRET value has been updated from "gemini" to "gemini-api-key" to align with existing configurations.
- AI Token Secret Key Update: The AI_TOKEN_SECRET_KEY value has been updated from "secret" to "api-key" for consistency.
- Configuration Alignment: These changes ensure that the secret names and keys in .tekton/jira.yaml match the setup from the .tekton/pr-labeler.yaml pipelinerun.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the secret name and key for the Jira AI token in the .tekton/jira.yaml
configuration file. The values for AI_TOKEN_SECRET
and AI_TOKEN_SECRET_KEY
have been updated to be more descriptive. This is a good change for clarity and maintainability. The changes are correct and I have no further feedback.
I have add another semi related minor commit to this that fix pr-labeler commit c04d756 (HEAD -> update-secret-for-jira-pipeline, chmouel/update-secret-for-jira-pipeline)
|
c04d756
to
ad9a48b
Compare
- Limit suggested labels to maximum of 3 (configurable via max_labels, default -1 for unlimited) - Only suggest "documentation" label when docs/ files are modified - Only suggest "e2e" label when test/ files are modified - Add validation logic to enforce these restrictions - Add "hack" to excluded labels list to avoid self-labeling - Update pipeline template to pass MAX_LABELS environment variable - Improve label limit logic to support unlimited labeling when max_labels <= 0 Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
ad9a48b
to
3d162ac
Compare
AI_TOKEN_SECRET
togemini-api-key
.AI_TOKEN_SECRET_KEY
toapi-key
.📝 Description of the Change
🔗 Linked GitHub Issue
Fixes #
👨🏻 Linked Jira
🚀 Type of Change
fix:
)feat:
)feat!:
,fix!:
)docs:
)chore:
)refactor:
)enhance:
)deps:
)🧪 Testing Strategy
✅ Submitter Checklist
fix:
,feat:
) matches the "Type of Change" I selected above.make test
andmake lint
locally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit install
toautomate these checks.