Skip to content

SPLAT-2299: FeatureGate - MultiDiskSetup #2388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2025
Merged

SPLAT-2299: FeatureGate - MultiDiskSetup #2388

merged 1 commit into from
Jul 4, 2025

Conversation

@jcpowermac
Copy link
Contributor

@jcpowermac jcpowermac commented Jul 1, 2025

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 1, 2025 •
edited by openshift-ci bot
Loading

@jcpowermac: This pull request references SPLAT-2299 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

This PR adds a new featuregate for the installer
to gate setting up multiple disks via machine config.

Changes

  • MultiDiskSetup feature gate

Additional / related PRs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 1, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2025

Hello @jcpowermac! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 1, 2025
@openshift-ci openshift-ci bot requested review from JoelSpeed and deads2k July 1, 2025 19:01
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2025
@vr4manta
Copy link
Contributor

vr4manta commented Jul 1, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2025
JoelSpeed
JoelSpeed reviewed Jul 2, 2025
View reviewed changes
features/features.go
enhancementPR("https://github.com/openshift/enhancements/pull/1804").
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
mustRegister()
FeatureGateMultiDiskSetup = newFeatureGate("MultiDiskSetup").
Copy link
Contributor

@JoelSpeed JoelSpeed Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, should have a new line between this gate and the previous

@jcpowermac
FeatureGate - MultiDiskSetup
03e897d 
This PR adds a new featuregate for the installer
to gate setting up multiple disks via machine config.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2025
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Jul 2, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, JoelSpeed, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 2, 2025

/retest-required

Remaining retests: 0 against base HEAD 9bbe393 and 2 for PR HEAD 03e897d in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 2, 2025

/retest-required

Remaining retests: 0 against base HEAD b76bb2c and 1 for PR HEAD 03e897d in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 3, 2025

/retest-required

Remaining retests: 0 against base HEAD b76bb2c and 2 for PR HEAD 03e897d in total

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 3, 2025

/retest-required

Remaining retests: 0 against base HEAD b76bb2c and 2 for PR HEAD 03e897d in total

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Jul 3, 2025

/retest-required

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Jul 3, 2025

hypershift apparently is having issues...

/retest-required

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 3, 2025

/retest-required

Remaining retests: 0 against base HEAD b76bb2c and 2 for PR HEAD 03e897d in total

2 similar comments
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 3, 2025

/retest-required

Remaining retests: 0 against base HEAD b76bb2c and 2 for PR HEAD 03e897d in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 4, 2025

/retest-required

Remaining retests: 0 against base HEAD b76bb2c and 2 for PR HEAD 03e897d in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 4, 2025 •
edited
Loading

@jcpowermac: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp 03e897d link false /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 4, 2025

/retest-required

Remaining retests: 0 against base HEAD b76bb2c and 2 for PR HEAD 03e897d in total

@openshift-merge-bot openshift-merge-bot bot merged commit ad766c4 into openshift:master Jul 4, 2025
25 of 26 checks passed
@openshift-bot
Copy link

openshift-bot commented Jul 4, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.20.0-202507041843.p0.gad766c4.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

1 more reviewer

@JoelSpeed JoelSpeed JoelSpeed left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@JoelSpeed JoelSpeed

@vr4manta vr4manta

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jcpowermac @openshift-ci-robot @vr4manta @JoelSpeed @openshift-bot @openshift-merge-robot