Skip to content

NO-JIRA: job-run-aggregator: remove relaxing in disruption aggregation #4899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
petr-muller wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

NO-JIRA: job-run-aggregator: remove relaxing in disruption aggregation #4899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60a820e
TRT-2487: job-run-aggregator: fail on minimum of 3 failures
petr-muller Jan 9, 2026
f180675
TRT-2487: job-run-aggregator: remove relaxing in disruption aggregation
petr-muller Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 32 additions & 7 deletions pkg/jobrunaggregator/jobrunaggregatoranalyzer/pass_fail.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,10 +501,9 @@ func (a *weeklyAverageFromTenDays) innerCheckPercentileDisruptionWithGrace(
numberOfPasses := len(successJobRunIDs)
numberOfFailures := len(failureJobRunIDs)
workingPercentage := thresholdPercentile // the percentile is our success percentage
requiredNumberOfPasses := requiredPassesByPassPercentageByNumberOfAttempts[numberOfAttempts][workingPercentage]
// TODO try to tighten this after we can keep the test in for about a week.
// We need to come back and revisit the possibility of removing this adjustment.
requiredNumberOfPasses = requiredNumberOfPasses - 1 // subtracting one because our current sample missed by one

strictRequiredNumberOfPasses := requiredPassesByPassPercentageByNumberOfAttempts[numberOfAttempts][workingPercentage]
requiredNumberOfPasses, pityFactorMsg := pityFactor(numberOfAttempts, strictRequiredNumberOfPasses)

if requiredNumberOfPasses <= 0 {
message := fmt.Sprintf("Current percentile is so low that we cannot latch, skipping (P%d=%.2fs successes=%v failures=%v)", thresholdPercentile, threshold, successRuns, failureRuns)
Expand Down Expand Up @@ -538,9 +537,16 @@ func (a *weeklyAverageFromTenDays) innerCheckPercentileDisruptionWithGrace(
return requiredNumberOfPasses, failureJobRunIDs, successJobRunIDs, testCaseFailed, summary
}

summary := fmt.Sprintf("Passed: Passed %d times, failed %d times. (P%d=%.2fs %srequiredPasses=%d successes=%v failures=%v)",
if numberOfPasses < strictRequiredNumberOfPasses {
pityFactorMsg = fmt.Sprintf(" (%s)", pityFactorMsg)
} else {
pityFactorMsg = ""
}

summary := fmt.Sprintf("Passed: Passed %d times, failed %d times%s. (P%d=%.2fs %srequiredPasses=%d successes=%v failures=%v)",
numberOfPasses,
numberOfFailures,
pityFactorMsg,
thresholdPercentile, threshold, graceAdded,
requiredNumberOfPasses,
successRuns, failureRuns,
Expand Down Expand Up @@ -614,7 +620,9 @@ func (a *weeklyAverageFromTenDays) CheckFailed(ctx context.Context, jobName stri
workingPercentage = int(averageTestResult.WorkingPercentage)
}

requiredNumberOfPasses := requiredPassesByPassPercentageByNumberOfAttempts[numberOfAttempts][workingPercentage]
strictRequiredNumberOfPasses := requiredPassesByPassPercentageByNumberOfAttempts[numberOfAttempts][workingPercentage]
requiredNumberOfPasses, pityFactorMsg := pityFactor(numberOfAttempts, strictRequiredNumberOfPasses)

if numberOfPasses < requiredNumberOfPasses {
summary := fmt.Sprintf("Failed: Passed %d times, failed %d times. The historical pass rate is %d%%. The required number of passes is %d.",
numberOfPasses,
Expand All @@ -625,14 +633,31 @@ func (a *weeklyAverageFromTenDays) CheckFailed(ctx context.Context, jobName stri
return testCaseFailed, summary, nil
}

return testCasePassed, fmt.Sprintf("Passed: Passed %d times, failed %d times. The historical pass rate is %d%%. The required number of passes is %d.",
if numberOfPasses < strictRequiredNumberOfPasses {
pityFactorMsg = fmt.Sprintf(" (%s)", pityFactorMsg)
} else {
pityFactorMsg = ""
}

return testCasePassed, fmt.Sprintf("Passed: Passed %d times, failed %d times. The historical pass rate is %d%%. The required number of passes is %d%s.",
numberOfPasses,
numberOfFailures,
workingPercentage,
requiredNumberOfPasses,
pityFactorMsg,
), nil
}

// pityFactor relaxes required success rate to always pass on 2 and fewer failures to reduce aggregation fails caused by
// e.g. infrastructure noise. We can afford to relax because component readiness will find genuine regressions over
// a larger sample size.
func pityFactor(numberOfAttempts int, strictRequiredNumberOfPasses int) (int, string) {
const failurePityFactor = 2
maxRequiredNumberOfPasses := max(0, numberOfAttempts-failurePityFactor)
requiredNumberOfPasses := min(maxRequiredNumberOfPasses, strictRequiredNumberOfPasses)
return requiredNumberOfPasses, fmt.Sprintf("strict required number of passes is %d but %d failures are allowed as pity factor", strictRequiredNumberOfPasses, failurePityFactor)
}

var testsRequiringHistoryRewrite = make(map[testCoordinates]string)

type testCoordinates struct {
Expand Down
Loading
Loading