Skip to content

Comments

NO-JIRA: Remove dead RELEASE_DIR ref#596

Open
stephenfin wants to merge 1 commit intoopenshift:mainfrom
shiftstack:remove-unused-RELEASE_DIR
Open

NO-JIRA: Remove dead RELEASE_DIR ref#596
stephenfin wants to merge 1 commit intoopenshift:mainfrom
shiftstack:remove-unused-RELEASE_DIR

Conversation

@stephenfin
Copy link

@stephenfin stephenfin commented Feb 24, 2026

Summary by CodeRabbit

Chores

  • Simplified the OpenShift manifest generation workflow by removing unnecessary prerequisite dependencies.
  • Enhanced manifest configuration capabilities with additional parameters for installation ordering, resource attributes, image reference management, platform specifications, and resource protection settings.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 24, 2026
@openshift-ci-robot
Copy link

@stephenfin: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@theobarberbany
Copy link

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Feb 24, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: theobarberbany

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 888e320 and 110a159.

📒 Files selected for processing (1)
  • openshift/Makefile

Walkthrough

The openshift/Makefile was updated to remove the $(RELEASE_DIR) dependency from the ocp-manifests target and to add additional flags (install order, attributes, image ref, platform, and resource protection) to the manifests-gen invocation.

Changes

Cohort / File(s) Summary
Makefile Configuration
openshift/Makefile
Removed $(RELEASE_DIR) prerequisite and directory-creation rule from ocp-manifests target; expanded manifests-gen parameters with additional flags for install order, attributes, image ref, platform, and resource protection.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing an unused RELEASE_DIR reference from the Makefile, which matches the changeset modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed The pull request only modifies openshift/Makefile, a build configuration file with no test definitions. The custom check for stable test names applies exclusively to test code, so it is not applicable and passes.
Test Structure And Quality ✅ Passed The custom check for test structure and quality is not applicable to this pull request. The PR only modifies openshift/Makefile to remove a dead reference to RELEASE_DIR - no test files were modified.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2026
@stephenfin
Copy link
Author

/override ci/prow/e2e-aws-capi-techpreview
/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-serial-1of2
/override ci/prow/e2e-aws-serial-2of2
/override ci/prow/e2e-hypershift

No point wasting CI resources on these.

@openshift-ci
Copy link

openshift-ci bot commented Feb 24, 2026

@stephenfin: stephenfin unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers.

Details

In response to this:

/override ci/prow/e2e-aws-capi-techpreview
/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-serial-1of2
/override ci/prow/e2e-aws-serial-2of2
/override ci/prow/e2e-hypershift

No point wasting CI resources on these.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@theobarberbany
Copy link

/override ci/prow/e2e-aws-capi-techpreview
/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-serial-1of2
/override ci/prow/e2e-aws-serial-2of2
/override ci/prow/e2e-hypershift

@openshift-ci
Copy link

openshift-ci bot commented Feb 24, 2026

@theobarberbany: Overrode contexts on behalf of theobarberbany: ci/prow/e2e-aws-capi-techpreview, ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-serial-1of2, ci/prow/e2e-aws-serial-2of2, ci/prow/e2e-hypershift

Details

In response to this:

/override ci/prow/e2e-aws-capi-techpreview
/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-serial-1of2
/override ci/prow/e2e-aws-serial-2of2
/override ci/prow/e2e-hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@theobarberbany
Copy link

/test unit

@theobarberbany
Copy link

/override ci/prow/regression-clusterinfra-aws-ipi-techpreview-capi

@openshift-ci
Copy link

openshift-ci bot commented Feb 24, 2026

@theobarberbany: Overrode contexts on behalf of theobarberbany: ci/prow/regression-clusterinfra-aws-ipi-techpreview-capi

Details

In response to this:

/override ci/prow/regression-clusterinfra-aws-ipi-techpreview-capi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link

openshift-ci bot commented Feb 24, 2026

@stephenfin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 110a159 link true /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants