-
Notifications
You must be signed in to change notification settings - Fork 147
dedicated event etcd draft PoC for ShiftWeek #1505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tjungblu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5920b8e to
689045c
Compare
|
Some quick benchmark results using:
This is running against the normal etcd: This is running against localhost in-memory: Now this is pretty crappy, let's try some tuning:
seems has no effect
also no real effect, leading me to believe this benchmark is not really disk bound in the first place. Checking the allocation route with:
Performs only slightly better. After CPU profiling, some interesting findings:
Unfortunately the grpc options for buffer sizes (R+W are at 32K each) need recompilation, so I won't be able to max this out any further today. |
| --- OR via SVC, as done below --- | ||
| - "/events#https://events-etcd.openshift-etcd.svc:20379" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this requires dnsPolicy=ClusterFirstWithHostNet on the kube-apiserver static pods
https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-dns-policy
This PR contains a dedicated in-memory etcd deployment that will run on one control plane host and configures the kube-apiserver to send events to it. Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
/hold
just here for CI runs and cluster bot builds