CNTRLPLANE-1315:Refactor OTE to single-module architecture #1510
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -68,3 +68,40 @@ topk(100, instance:etcd_mvcc_db_total_size_in_use_in_bytes:sum) | |
| ```console | ||
| sum without (_id) (quantile by (_id)(0.5, instance:etcd_disk_backend_commit_duration_seconds:histogram_quantile{quantile="0.99"}) + on(_id) group_left(provider) (topk by (_id) (1, id_provider*0))) | ||
| ``` | ||
|
|
||
| ## Tests | ||
|
|
||
| This repository is compatible with the [OpenShift Tests Extension (OTE)](https://github.com/openshift-eng/openshift-tests-extension) framework. | ||
|
|
||
| ### Building the test binary | ||
|
|
||
| ```bash | ||
| make build | ||
| ``` | ||
|
|
||
| ### Running test suites and tests | ||
|
|
||
| ```bash | ||
| # Run a specific test suite or test | ||
| ./cluster-etcd-operator-tests-ext run-suite openshift/cluster-etcd-operator/all | ||
| ./cluster-etcd-operator-tests-ext run-test "test-name" | ||
|
|
||
| # Run with JUnit output | ||
| ./cluster-etcd-operator-tests-ext run-suite openshift/cluster-etcd-operator/all --junit-path=/tmp/junit-results/junit.xml | ||
|
There was a problem hiding this comment. For junit report: https://github.com/openshift/cluster-kube-apiserver-operator/blob/main/README.md?plain=1#L200 we used
Contributor
Author
There was a problem hiding this comment. no that is wrong see old readme ./cluster-etcd-operator-tests-ext run-suite openshift/cluster-etcd-operator/conformance/parallel --junit-path
Contributor
Author
There was a problem hiding this comment. |
||
| ./cluster-etcd-operator-tests-ext run-test "test-name" --junit-path=/tmp/junit-results/junit.xml | ||
| ``` | ||
|
|
||
| ### Listing available tests and suites | ||
|
|
||
| ```bash | ||
| # List all test suites | ||
| ./cluster-etcd-operator-tests-ext list suites | ||
|
|
||
| # List tests in a suite | ||
| ./cluster-etcd-operator-tests-ext list tests --suite=openshift/cluster-etcd-operator/all | ||
|
|
||
| #for concurrency | ||
| ./cluster-etcd-operator-tests-ext run-suite openshift/cluster-etcd-operator/all -c 1 | ||
| ``` | ||
|
|
||
| For more information about the OTE framework, see the [openshift-tests-extension documentation](https://github.com/openshift-eng/openshift-tests-extension). | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,105 +1,66 @@ | ||
| /* | ||
| This command is used to run the Cluster Etcd Operator tests extension for OpenShift. | ||
| It registers the Cluster Etcd Operator tests with the OpenShift Tests Extension framework | ||
| and provides a command-line interface to execute them. | ||
| For further information, please refer to the documentation at: | ||
| https://github.com/openshift-eng/openshift-tests-extension/blob/main/cmd/example-tests/main.go | ||
| */ | ||
| package main | ||
|
|
||
| import ( | ||
| "context" | ||
| "os" | ||
|
|
||
| "github.com/spf13/cobra" | ||
| "k8s.io/component-base/cli" | ||
|
|
||
| otecmd "github.com/openshift-eng/openshift-tests-extension/pkg/cmd" | ||
| oteextension "github.com/openshift-eng/openshift-tests-extension/pkg/extension" | ||
| "github.com/openshift/cluster-etcd-operator/pkg/version" | ||
|
|
||
| "k8s.io/klog/v2" | ||
| ) | ||
|
|
||
| func main() { | ||
| command := newOperatorTestCommand(context.Background()) | ||
| code := cli.Run(command) | ||
| os.Exit(code) | ||
| } | ||
|
|
||
| func newOperatorTestCommand(ctx context.Context) *cobra.Command { | ||
| registry := prepareOperatorTestsRegistry() | ||
|
|
||
| cmd := &cobra.Command{ | ||
| Use: "cluster-etcd-operator-tests", | ||
| Short: "A binary used to run cluster-etcd-operator tests as part of OTE.", | ||
| Run: func(cmd *cobra.Command, args []string) { | ||
| // no-op, logic is provided by the OTE framework | ||
| if err := cmd.Help(); err != nil { | ||
| klog.Fatal(err) | ||
| } | ||
| }, | ||
| } | ||
|
|
||
| if v := version.Get().String(); len(v) == 0 { | ||
| cmd.Version = "<unknown>" | ||
| } else { | ||
| cmd.Version = v | ||
| } | ||
|
|
||
| cmd.AddCommand(otecmd.DefaultExtensionCommands(registry)...) | ||
|
|
||
| return cmd | ||
| } | ||
|
|
||
| // prepareOperatorTestsRegistry creates the OTE registry for this operator. | ||
| // | ||
| // Note: | ||
| // | ||
| // This method must be called before adding the registry to the OTE framework. | ||
| func prepareOperatorTestsRegistry() *oteextension.Registry { | ||
| registry := oteextension.NewRegistry() | ||
| extension := oteextension.NewExtension("openshift", "payload", "cluster-etcd-operator") | ||
|
|
||
| registry.Register(extension) | ||
| return registry | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| reviewers: | ||
| - dusk125 | ||
| - ironcladlou | ||
| - hasbro17 | ||
| - tjungblu | ||
| - jubittajohn | ||
| - wangke19 | ||
|
|
||
| - gangwgr | ||
| - geliu2016 | ||
| - sandeepknd | ||
| approvers: | ||
| - deads2k | ||
| - hasbro17 | ||
| - dusk125 | ||
| - tjungblu | ||
| - wangke19 | ||
| - gangwgr | ||
| - geliu2016 | ||
| - sandeepknd | ||
| component: "Etcd" | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 15 has the same. why is
cluster-etcd-operator-tests-ext.gzremoved?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/openshift/cluster-kube-apiserver-operator/blob/main/.gitignore#L10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It never zip on local no need