Skip to content

Comments

OCPBUGS-65484: Add ClusterRole to ClusterOperator relatedObjects#283

Draft
RadekManak wants to merge 1 commit intoopenshift:mainfrom
RadekManak:add-clusterrole-relatedobjects
Draft

OCPBUGS-65484: Add ClusterRole to ClusterOperator relatedObjects#283
RadekManak wants to merge 1 commit intoopenshift:mainfrom
RadekManak:add-clusterrole-relatedobjects

Conversation

@RadekManak
Copy link
Contributor

@RadekManak RadekManak commented Nov 12, 2025

This adds the system:openshift:controller:machine-approver ClusterRole to the ClusterOperator's relatedObjects to ensure it's collected by oc adm inspect and must-gather for debugging purposes.

🤖 Generated with Claude Code

@RadekManak @claude
Add ClusterRole to ClusterOperator relatedObjects
9707b28 
This adds the system:openshift:controller:machine-approver ClusterRole
to the ClusterOperator's relatedObjects to ensure it's collected by
oc adm inspect and must-gather for debugging purposes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 12, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 12, 2025

@RadekManak: This pull request references Jira Issue OCPBUGS-65484, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This adds the system:openshift:controller:machine-approver ClusterRole to the ClusterOperator's relatedObjects to ensure it's collected by oc adm inspect and must-gather for debugging purposes.

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign radekmanak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

wking
wking reviewed Nov 12, 2025
View reviewed changes
status.go
},
{
Group: "rbac.authorization.k8s.io",
Resource: "clusterroles",
Copy link
Member

@wking wking Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a ClusterRole all you need? I'd expect you'd also need a ClusterRoleBinding that attaches that role to a ServiceAccount? And maybe other things?

@RadekManak RadekManak marked this pull request as draft November 12, 2025 17:36
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 12, 2025
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 13, 2026

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunzhaohua2 sunzhaohua2 Awaiting requested review from sunzhaohua2

@nrb nrb Awaiting requested review from nrb

@theobarberbany theobarberbany Awaiting requested review from theobarberbany

1 more reviewer

@wking wking wking left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RadekManak @openshift-ci-robot @openshift-bot @wking