Skip to content

Comments

OCPCLOUD-3347: tls: use centralized TLS profile#286

Open
damdo wants to merge 3 commits intoopenshift:mainfrom
damdo:use-centralized-tls-profile
Open

OCPCLOUD-3347: tls: use centralized TLS profile#286
damdo wants to merge 3 commits intoopenshift:mainfrom
damdo:use-centralized-tls-profile

Conversation

@damdo
Copy link
Member

@damdo damdo commented Jan 20, 2026

Start using centralized TLS profile fetched from the APIServer configuration.
Remove kube-rbac-proxy

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 20, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 20, 2026

@damdo: This pull request references OCPCLOUD-3347 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 20, 2026

@damdo: This pull request references OCPCLOUD-3347 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Start using centralized TLS profile fetched from the APIServer configuration.
Remove kube-rbac-proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from chrischdi and nrb January 20, 2026 14:42
@damdo damdo force-pushed the use-centralized-tls-profile branch from 1739832 to 4011872 Compare January 20, 2026 16:27
@damdo
Copy link
Member Author

damdo commented Jan 20, 2026

Units will be fixed by #287

@damdo damdo force-pushed the use-centralized-tls-profile branch from 4011872 to 9349d48 Compare January 20, 2026 20:35
@damdo
Copy link
Member Author

damdo commented Jan 21, 2026

/retest

@damdo
Copy link
Member Author

damdo commented Jan 22, 2026

/hold

until we sort the main library

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2026
@damdo damdo force-pushed the use-centralized-tls-profile branch from 9349d48 to 056043e Compare February 3, 2026 18:29
@damdo
Copy link
Member Author

damdo commented Feb 4, 2026

/retest

@damdo damdo force-pushed the use-centralized-tls-profile branch 2 times, most recently from df73dbb to bc9c1ce Compare February 4, 2026 21:49
@damdo
Copy link
Member Author

damdo commented Feb 5, 2026

/test e2e-aws-operator

@damdo
Copy link
Member Author

damdo commented Feb 5, 2026

/test e2e-aws-capi-techpreview

@damdo
Copy link
Member Author

damdo commented Feb 5, 2026

/assign @RadekManak

@damdo
Copy link
Member Author

damdo commented Feb 6, 2026

/test e2e-aws-capi-techpreview

@damdo damdo force-pushed the use-centralized-tls-profile branch 3 times, most recently from a05cbe0 to b556534 Compare February 8, 2026 16:37
@RadekManak
Copy link
Contributor

/lgtm
/hold cancel

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 9, 2026
@damdo damdo force-pushed the use-centralized-tls-profile branch from b556534 to 74d6739 Compare February 14, 2026 09:08
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2026
@damdo damdo force-pushed the use-centralized-tls-profile branch from 74d6739 to 8e3a98f Compare February 14, 2026 09:11
@damdo damdo force-pushed the use-centralized-tls-profile branch from 8e3a98f to 2000f73 Compare February 14, 2026 09:55
@RadekManak
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RadekManak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2026
@miyadav
Copy link
Member

miyadav commented Feb 17, 2026

Thanks @damdo for insights into testing these , updated results on shared sheet for CMA , based on that adding label .

/verified by @miyadav

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 17, 2026
@openshift-ci-robot
Copy link
Contributor

@miyadav: This PR has been marked as verified by @miyadav.

Details

In response to this:

Thanks @damdo for insights into testing these , updated results on shared sheet for CMA , based on that adding label .

/verified by @miyadav

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@damdo
Copy link
Member Author

damdo commented Feb 17, 2026

/test e2e-aws-capi-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 17, 2026

@damdo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-capi-techpreview 2000f73 link true /test e2e-aws-capi-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@damdo
Copy link
Member Author

damdo commented Feb 24, 2026

/tide refresh

@damdo
Copy link
Member Author

damdo commented Feb 24, 2026

/test e2e-aws-capi-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2026

@damdo: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-aws
/test e2e-aws-capi-techpreview
/test e2e-aws-operator
/test e2e-upgrade
/test images
/test okd-scos-images
/test unit
/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-azure-operator
/test e2e-gcp-operator
/test okd-scos-e2e-aws-ovn

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-cluster-machine-approver-main-e2e-aws
pull-ci-openshift-cluster-machine-approver-main-e2e-aws-capi-techpreview
pull-ci-openshift-cluster-machine-approver-main-e2e-aws-operator
pull-ci-openshift-cluster-machine-approver-main-e2e-upgrade
pull-ci-openshift-cluster-machine-approver-main-images
pull-ci-openshift-cluster-machine-approver-main-okd-scos-images
pull-ci-openshift-cluster-machine-approver-main-unit
pull-ci-openshift-cluster-machine-approver-main-verify-deps
Details

In response to this:

/test ci/prow/e2e-aws-capi-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants