Skip to content

OCPCLOUD-3347: tls: use centralized TLS profile (unrevert)#292

Open
damdo wants to merge 3 commits intoopenshift:mainfrom
damdo:use-centralized-tls-profile-2
Open

OCPCLOUD-3347: tls: use centralized TLS profile (unrevert)#292
damdo wants to merge 3 commits intoopenshift:mainfrom
damdo:use-centralized-tls-profile-2

Conversation

@damdo
Copy link
Member

@damdo damdo commented Feb 25, 2026

Unrevert of the revert #291, to reintroduce #286

--

Start using centralized TLS profile fetched from the APIServer configuration.
Remove kube-rbac-proxy

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 25, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 25, 2026

@damdo: This pull request references OCPCLOUD-3347 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Unrevert of the revert #291, to reintroduce #286

--

Start using centralized TLS profile fetched from the APIServer configuration.
Remove kube-rbac-proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@damdo damdo requested a review from RadekManak February 25, 2026 19:33
@damdo
Copy link
Member Author

damdo commented Feb 25, 2026

/hold

For HCP to sort out the RBAC permission issue

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2026
@openshift-ci openshift-ci bot requested review from nrb and theobarberbany February 25, 2026 19:33
@damdo
Copy link
Member Author

damdo commented Feb 25, 2026

/cc @neisw @bryan-cox

@openshift-ci openshift-ci bot requested review from bryan-cox and neisw February 25, 2026 19:33
Copy link
Member Author

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 25, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2026
@damdo damdo force-pushed the use-centralized-tls-profile-2 branch from 2458331 to 357265a Compare February 25, 2026 19:51
@sjenning
Copy link
Contributor

/hold

until the hypershift presubmit jobs are in place openshift/release#75309

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 26, 2026

@damdo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-capi-techpreview 357265a link true /test e2e-aws-capi-techpreview
ci/prow/e2e-hypershift-aks 357265a link true /test e2e-hypershift-aks
ci/prow/e2e-upgrade 357265a link true /test e2e-upgrade
ci/prow/e2e-hypershift-aws 357265a link true /test e2e-hypershift-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants