OCPBUGS-59135,OCPBUGS-59134: Annotate whereabouts-controller #2749
Conversation
bpickard22
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@bpickard22: This pull request references Jira Issue OCPBUGS-59135, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@bpickard22: This pull request references Jira Issue OCPBUGS-59135, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Add target.workload.openshift.io/management: '{"effect":
"PreferredDuringScheduling"}' annotation to whereabouts-controller
deployment to satisfy
_sig-node__apigroup_config.openshift.io__CPU_Partitioning_cluster_platform_workloads_should_be_annotated_correctly_for_Deployments__Suite_openshift/conformance/parallel_
job
Remove resource limits on whereabouts controller to satisfy ShiftOnStack
conformence test `Pods in platform namespaces are not following resource
request/limit rules or do not have an exception granted`
Signed-off-by: Benjamin Pickard <bpickard@redhat.com>
s
bpickard22
force-pushed
the
workload-annotation
branch
from
ffa0572 to
34aa4b4
Compare
bpickard22
changed the title
|
@bpickard22: This pull request references Jira Issue OCPBUGS-59135, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-59134, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@bpickard22: This pull request references Jira Issue OCPBUGS-59135, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request. This pull request references Jira Issue OCPBUGS-59134, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
/lgtm |
|
/retest-required |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bpickard22, kyrtapz, pliurh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@bpickard22: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit bf88d53
into
openshift:master
|
@bpickard22: Jira Issue OCPBUGS-59135: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-59135 has been moved to the MODIFIED state. Jira Issue OCPBUGS-59134: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-59134 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: cluster-network-operator |
|
/cherrypick release-4.19 |
|
@pliurh: new pull request created: #2822 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6 participants
Add target.workload.openshift.io/management: '{"effect": "PreferredDuringScheduling"}' annotation to whereabouts-controller deployment to satisfy
sig-node__apigroup_config.openshift.io__CPU_Partitioning_cluster_platform_workloads_should_be_annotated_correctly_for_Deployments__Suite_openshift/conformance/parallel job
Remove resource limits on whereabouts controller to satisfy ShiftOnStack
conformence test
Pods in platform namespaces are not following resource request/limit rules or do not have an exception granted