Skip to content

OCPBUGS-62496: hypershift:e2e:status: check for duplicated configmap status #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

OCPBUGS-62496: hypershift:e2e:status: check for duplicated configmap status #1413

wants to merge 2 commits into from

Conversation

@Tal-or
Copy link
Contributor

@Tal-or Tal-or commented Oct 16, 2025 •
edited
Loading

Check that PerformanceProfile replacement doesn't add
additional configmap status.

This test is excersing the bug to avoid regressions in the future.

The fix filed for Hypershift repo: openshift/hypershift#7089

Signed-off-by: Talor Itzhak titzhak@redhat.com

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 16, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 16, 2025

@Tal-or: This pull request references Jira Issue OCPBUGS-62496, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

on hypershift platform,
when PerformanceProfile gets replaced with a new one,
there will be a short window when two different PerformanceProfile are exist for the same nodePool
until Hypershift operator catches up and deletes the old one.
in this case, we want to avoid creating duplicated ConfigMap for the status because it will
break Hypershift reconciliation loop:
https://github.com/openshift/hypershift/blob/53dc14cbdd1e46d8b648ed49c6419d34209ef406/hypershift-operator/controllers/nodepool/nto.go#L330

if a different ConfigMap for the status already exists, requeue the object for later.

Signed-off-by: Talor Itzhak titzhak@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from ffromani and yanirq October 16, 2025 10:10
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Tal-or
Once this PR has been reviewed and has the lgtm label, please assign ffromani for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Tal-or
Copy link
Contributor Author

Tal-or commented Oct 16, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2025
@Tal-or
Copy link
Contributor Author

Tal-or commented Oct 19, 2025

/retest

@Tal-or Tal-or force-pushed the hcp_cm_status branch 3 times, most recently from ec3fe7f to b31802c Compare October 20, 2025 12:00
@Tal-or
Copy link
Contributor Author

Tal-or commented Oct 21, 2025

/retest

Tal-or added a commit to Tal-or/hypershift that referenced this pull request Oct 23, 2025
@Tal-or
nto:delete old profile during replacement
dfcd763 
When a PerformanceProfile is being replaced for a NodePool,
hypershift controller lack the logic to delete the old
profile from the HCP namespace.

This commit resolve this gap.
A dedicated e2e test coverage was added on NTO repo:
openshift/cluster-node-tuning-operator#1413

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@Tal-or Tal-or changed the title OCPBUGS-62496: hypershift:status: check for duplicated configmap status OCPBUGS-62496: hypershift:status:e2e: check for duplicated configmap status Oct 23, 2025
@Tal-or Tal-or changed the title OCPBUGS-62496: hypershift:status:e2e: check for duplicated configmap status OCPBUGS-62496: hypershift:e2e:status: check for duplicated configmap status Oct 23, 2025
@Tal-or
e2e: check PerformanceProfile replacement
45c1746 
Check that PerformanceProfile replacement doesn't add
additional configmap status.

This test is excersing the bug to avoid regressions in the future.

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Tal-or added a commit to Tal-or/hypershift that referenced this pull request Oct 23, 2025
@Tal-or
nto:delete old profile during replacement
91b0340 
When a PerformanceProfile is being replaced for a NodePool,
hypershift controller lack the logic to delete the old
profile from the HCP namespace.

This commit resolve this gap.
A dedicated e2e test coverage was added on NTO repo:
openshift/cluster-node-tuning-operator#1413

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@Tal-or Tal-or mentioned this pull request Oct 23, 2025
Merged
2 tasks
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 23, 2025

@Tal-or: This pull request references Jira Issue OCPBUGS-62496, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Check that PerformanceProfile replacement doesn't add
additional configmap status.

This test is excersing the bug to avoid regressions in the future.

Signed-off-by: Talor Itzhak titzhak@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Tal-or
Copy link
Contributor Author

Tal-or commented Oct 23, 2025 •
edited
Loading

/hold
depends on: openshift/hypershift#7089
tested locally, with the above patch, the test is passing.

Tal-or added a commit to Tal-or/hypershift that referenced this pull request Oct 23, 2025
@Tal-or
fix: OCPBUGS-62496 delete old profile during replacement
eb473ef 
When a PerformanceProfile is being replaced for a NodePool,
hypershift controller lack the logic to delete the old
profile from the HCP namespace.

This commit resolve this gap.
A dedicated e2e test coverage was added on NTO repo:
openshift/cluster-node-tuning-operator#1413

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Tal-or added a commit to Tal-or/hypershift that referenced this pull request Oct 23, 2025
@Tal-or
fix: OCPBUGS-62496 delete old profile during replacement
ed3c3cc 
When a PerformanceProfile is being replaced for a NodePool,
hypershift controller lack the logic to delete the old
profile from the HCP namespace.

This commit resolve this gap.
A dedicated e2e test coverage was added on NTO repo:
openshift/cluster-node-tuning-operator#1413

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@Tal-or
Copy link
Contributor Author

Tal-or commented Oct 29, 2025

/hold cancel
/retest

openshift/hypershift#7089 got merged

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2025
@Tal-or
Copy link
Contributor Author

Tal-or commented Oct 30, 2025

/retest

mgencur pushed a commit to mgencur/hypershift that referenced this pull request Oct 30, 2025
@Tal-or @mgencur
fix: OCPBUGS-62496 delete old profile during replacement
9c7c886 
When a PerformanceProfile is being replaced for a NodePool,
hypershift controller lack the logic to delete the old
profile from the HCP namespace.

This commit resolve this gap.
A dedicated e2e test coverage was added on NTO repo:
openshift/cluster-node-tuning-operator#1413

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
mgencur pushed a commit to mgencur/hypershift that referenced this pull request Oct 30, 2025
@Tal-or @mgencur
fix: OCPBUGS-62496 delete old profile during replacement
57a0326 
When a PerformanceProfile is being replaced for a NodePool,
hypershift controller lack the logic to delete the old
profile from the HCP namespace.

This commit resolve this gap.
A dedicated e2e test coverage was added on NTO repo:
openshift/cluster-node-tuning-operator#1413

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@Tal-or
Copy link
Contributor Author

Tal-or commented Nov 4, 2025

/retest

@Tal-or
makefile: filter hypershift tests from the non-hypershift lane
3e57d6d 
Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@Tal-or
Copy link
Contributor Author

Tal-or commented Nov 5, 2025

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2025

@Tal-or: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ffromani ffromani Awaiting requested review from ffromani

@yanirq yanirq Awaiting requested review from yanirq

Assignees

No one assigned

Labels

jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Tal-or @openshift-ci-robot