Skip to content

Conversation

@Tal-or
Copy link
Contributor

@Tal-or Tal-or commented Oct 30, 2025

A new version of irqbalance start using IRQBALANCE_BANNED_CPULIST to mark the banned CPUs
that are not suppose to participate in the irq balancing.

We're setting the new variable with a default value - which
means that all CPUs are participating in the irq balancing.

Signed-off-by: Talor Itzhak titzhak@redhat.com

new version of irqbalance start using IRQBALANCE_BANNED_CPULIST to mark the banned CPUs
that are not suppose to participate in the irq balancing.

We're setting the new variable with a default value `-` which
means that all CPUs are participating in the irq balancing.

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
This is only needed for cases when more
control is required on the restore flow.
cri-o/cri-o@e158549

In our case we do not need the restore flow at all, because
the default behavior of the dynamic irqbalancing provided by cri-o
is good enough for us.

hence, we disable the restore flow completely.

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@Tal-or
Copy link
Contributor Author

Tal-or commented Oct 30, 2025

/hold

depends on cri-o/cri-o#8931

Closed by mistake

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2025
@openshift-ci openshift-ci bot requested review from MarSik and yanirq October 30, 2025 14:13
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Tal-or
Once this PR has been reviewed and has the lgtm label, please assign marsik for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Tal-or
Copy link
Contributor Author

Tal-or commented Oct 30, 2025

same as #1350 which was closed by mistake

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2025

@Tal-or: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn dbdf5a5 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-pao-updating-profile dbdf5a5 link true /test e2e-gcp-pao-updating-profile
ci/prow/e2e-aws-ovn-techpreview dbdf5a5 link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-gcp-pao-workloadhints dbdf5a5 link true /test e2e-gcp-pao-workloadhints
ci/prow/e2e-hypershift-pao dbdf5a5 link true /test e2e-hypershift-pao
ci/prow/e2e-gcp-pao dbdf5a5 link true /test e2e-gcp-pao

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant