Skip to content

[release-4.20] OCPBUGS-63751: PPC: ghw: filter out namespaces dir #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: release-4.20
Choose a base branch
from
Open

[release-4.20] OCPBUGS-63751: PPC: ghw: filter out namespaces dir #1421

wants to merge 2 commits into from
+33 −28

Conversation

@openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1403

/assign shajmakh

@shajmakh
PPC: pkg: public consts to private
22939d6 
The consts are not used anywhere else so make them private.

Signed-off-by: Shereen Haj <shajmakh@redhat.com>
@shajmakh
PPC: ghw: filter out namespaces dir
04186b8 
The previous code fails to run PPC when there is a namespace that has a
suffix `nodes`. ensure filtering the namespace directory to allow PPC to
work when such namespaces exist.

Signed-off-by: Shereen Haj <shajmakh@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 31, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-60218 has been cloned as Jira Issue OCPBUGS-63751. Will retitle bug to link to clone.
/retitle [release-4.20] OCPBUGS-63751: PPC: ghw: filter out namespaces dir

In response to this:

This is an automated cherry-pick of #1403

/assign shajmakh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.20] OCPBUGS-60218: PPC: ghw: filter out namespaces dir [release-4.20] OCPBUGS-63751: PPC: ghw: filter out namespaces dir Oct 31, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 31, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-63751, which is invalid:

  • expected dependent Jira Issue OCPBUGS-60218 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1403

/assign shajmakh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from MarSik and jmencak October 31, 2025 18:50
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign marsik for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2025

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jmencak
Copy link
Contributor

jmencak commented Nov 1, 2025

/lgtm
/approved
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 1, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmencak jmencak Awaiting requested review from jmencak

@MarSik MarSik Awaiting requested review from MarSik

Assignees

@jmencak jmencak

@shajmakh shajmakh

Labels

backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @openshift-ci-robot @jmencak @shajmakh