STOR-2523: hypershift: Add desired-version annotation to operand Deployments and use DeploymentVersionController in CSO #638
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@mpatlasov: This pull request references STOR-2523 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mpatlasov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
1 similar comment
|
/retest-required |
|
/assign @jsafrane |
|
@mpatlasov: This pull request references STOR-2523 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
mpatlasov
force-pushed
the
STOR-2523-Add-desired-version-annotation
branch
from
0a05ff2 to
c8afe69
Compare
mpatlasov
force-pushed
the
STOR-2523-Add-desired-version-annotation
branch
from
c8afe69 to
15fdfe0
Compare
|
@jsafrane , the PR is ready for review (last commit implements DeploymentVersionController). PTAL |
mpatlasov
force-pushed
the
STOR-2523-Add-desired-version-annotation
branch
from
15fdfe0 to
64cf8b0
Compare
|
/retest-required |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
mpatlasov
changed the title
New annotation `release.openshift.io/desired-version` will be used by CSO to compare the version from env var `OPERATOR_IMAGE_VERSION` with actual version of currently running operand.
`go get github.com/openshift/library-go`
New annotation `release.openshift.io/version` signals that rollout of Deployment is complete (see https://issues.redhat.com/browse/STOR-2523 for details). This commit uses new controller (DeploymentVersionController) from library-go which reconciles version annotation if controller deplyment is done.
mpatlasov
force-pushed
the
STOR-2523-Add-desired-version-annotation
branch
from
64cf8b0 to
1a3bf7c
Compare
|
Update: last force-push only rebased PR on top of current head of main branch. |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/override ci/prow/okd-scos-images |
|
@mpatlasov: Overrode contexts on behalf of mpatlasov: ci/prow/okd-scos-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mpatlasov: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
New annotation
release.openshift.io/desired-versionwill be used by CSO to compare the version from env varOPERATOR_IMAGE_VERSIONwith actual version of currently running operand.