[release-4.21] OCPBUGS-79035: Fix TypeError in OLS code import to console#16184
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-77912 has been cloned as Jira Issue OCPBUGS-79035. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-79035, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
/lgtm |
|
/retest |
The "Import to console" action from OpenShift Lightspeed was failing with "TypeError: Cannot use 'in' operator to search for 'editor' in undefined" when redirecting to the YAML import page. The issue occurred in getEditor() where the 'in' operator was used on monacoRef.current before checking if it was defined. This created a race condition where the OLS code import useEffect would run when editorMounted became true, but monacoRef.current was still undefined. The fix adds a check to ensure monacoRef.current exists before using the 'in' operator, preventing the TypeError and allowing the OLS code to be properly injected into the editor. Added regression tests to verify the fix handles all cases correctly. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
rhamilto
force-pushed
the
cherry-pick-16119-to-release-4.21
branch
from
755d829 to
4b6c245
Compare
|
/approve |
openshift-ci
bot
added
the
backport-risk-assessed
openshift-ci
bot
added
the
approved
|
/test backend |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyoto, logonoff, openshift-cherrypick-robot, rhamilto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9 participants
This is an automated cherry-pick of #16119
/assign rhamilto
/cherrypick release-4.20