Skip to content

OCPBUGS-79678: Align the search input so that its next to the select menu toggle#16198

Open
sg00dwin wants to merge 1 commit intoopenshift:mainfrom
sg00dwin:OCPBUGS-79678-api-resource-search-input
Open

OCPBUGS-79678: Align the search input so that its next to the select menu toggle#16198
sg00dwin wants to merge 1 commit intoopenshift:mainfrom
sg00dwin:OCPBUGS-79678-api-resource-search-input

Conversation

@sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented Mar 25, 2026

Minor visual realignment

Before
Screenshot 2026-03-25 at 5 55 23 PM

After
Screenshot 2026-03-25 at 6 10 38 PM

Summary by CodeRabbit

  • Style
    • Updated the layout alignment of the text filter control in the API explorer to use default positioning instead of right alignment.

@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 25, 2026
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: This pull request references Jira Issue OCPBUGS-79678, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Minor visual realignment

Before
Screenshot 2026-03-25 at 5 55 23 PM

After
Screenshot 2026-03-25 at 6 10 38 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from TheRealJon and jhadvig March 25, 2026 22:16
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Mar 25, 2026
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: This pull request references Jira Issue OCPBUGS-79678, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

Minor visual realignment

Before
Screenshot 2026-03-25 at 5 55 23 PM

After
Screenshot 2026-03-25 at 6 10 38 PM

Summary by CodeRabbit

  • Style
  • Updated the layout alignment of the text filter control in the API explorer to use default positioning instead of right alignment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: c84216f5-b183-4bf3-a7b0-25f90abbc08f

📥 Commits

Reviewing files that changed from the base of the PR and between 1425db6 and 68bf1a0.

📒 Files selected for processing (1)
  • frontend/public/components/api-explorer.tsx
📜 Recent review details
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

  • frontend/public/components/api-explorer.tsx
🔇 Additional comments (1)
frontend/public/components/api-explorer.tsx (1)

827-833: LGTM — Layout realignment looks correct.

Removing the align={{ default: 'alignRight' }} from the TextFilter's FlexItem allows it to flow naturally next to the verb selector, while the Pagination at line 834 retains its right alignment. This matches the intended visual shown in the PR screenshots and follows standard PatternFly Flex behavior.


📝 Walkthrough

Walkthrough

The APIResourceAccessReview component in api-explorer.tsx removes explicit right alignment from a FlexItem wrapping a TextFilter control. The align={{ default: 'alignRight' }} prop is removed, allowing the control to adopt the default PatternFly Flex layout behavior instead of being positioned to the right.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 26, 2026

@sg00dwin: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants