Skip to content

spike: Kubevirt networkdata #7299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
qinqon wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

spike: Kubevirt networkdata #7299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions api/hypershift/v1beta1/kubevirt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,13 @@ type KubevirtNodePoolPlatform struct {
// +optional
// +kubebuilder:validation:MaxItems=10
KubevirtHostDevices []KubevirtHostDevice `json:"hostDevices,omitempty"`

// networkData is inline cloud-init network data configuration for VMs in this NodePool.
// When specified, cloud-init volume changes from ConfigDrive to NoCloud.
// This allows for static network configuration of VMs.
// +kubebuilder:validation:MaxLength=2048
// +optional
NetworkData *string `json:"networkData,omitempty"`
}

// KubevirtNetwork specifies the configuration for a virtual machine
Expand Down
5 changes: 5 additions & 0 deletions api/hypershift/v1beta1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions ...z_generated.featuregated-crd-manifests/nodepools.hypershift.openshift.io/AAA_ungated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1102,6 +1102,13 @@ spec:
type: object
maxItems: 10
type: array
networkData:
description: |-
networkData is inline cloud-init network data configuration for VMs in this NodePool.
When specified, cloud-init volume changes from ConfigDrive to NoCloud.
This allows for static network configuration of VMs.
maxLength: 2048
type: string
networkInterfaceMultiqueue:
default: Enable
description: |-
Expand Down
7 changes: 7 additions & 0 deletions .../zz_generated.featuregated-crd-manifests/nodepools.hypershift.openshift.io/OpenStack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1102,6 +1102,13 @@ spec:
type: object
maxItems: 10
type: array
networkData:
description: |-
networkData is inline cloud-init network data configuration for VMs in this NodePool.
When specified, cloud-init volume changes from ConfigDrive to NoCloud.
This allows for static network configuration of VMs.
maxLength: 2048
type: string
networkInterfaceMultiqueue:
default: Enable
description: |-
Expand Down
9 changes: 9 additions & 0 deletions client/applyconfiguration/hypershift/v1beta1/kubevirtnodepoolplatform.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions ...ssets/cluster-api-provider-kubevirt/infrastructure.cluster.x-k8s.io_kubevirtmachines.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,11 @@ spec:
type: string
type: object
x-kubernetes-map-type: atomic
networkData:
description: |-
NetworkData contains inline cloud-init network data configuration.
When specified, the cloud-init volume will use NoCloud instead of ConfigDrive.
type: string
providerID:
description: ProviderID TBD what to use for Kubevirt
type: string
Expand Down
5 changes: 5 additions & 0 deletions ...uster-api-provider-kubevirt/infrastructure.cluster.x-k8s.io_kubevirtmachinetemplates.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,11 @@ spec:
type: string
type: object
x-kubernetes-map-type: atomic
networkData:
description: |-
NetworkData contains inline cloud-init network data configuration.
When specified, the cloud-init volume will use NoCloud instead of ConfigDrive.
type: string
providerID:
description: ProviderID TBD what to use for Kubevirt
type: string
Expand Down
194 changes: 194 additions & 0 deletions cmd/install/assets/hypershift-operator/awsendpointservices.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,194 @@
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
api.openshift.io/merged-by-featuregates: "true"
include.release.openshift.io/ibm-cloud-managed: "true"
include.release.openshift.io/self-managed-high-availability: "true"
name: awsendpointservices.hypershift.openshift.io
spec:
group: hypershift.openshift.io
names:
kind: AWSEndpointService
listKind: AWSEndpointServiceList
plural: awsendpointservices
singular: awsendpointservice
scope: Namespaced
versions:
- name: v1beta1
schema:
openAPIV3Schema:
description: AWSEndpointService specifies a request for an Endpoint Service
in AWS
properties:
apiVersion:
description: |-
APIVersion defines the versioned schema of this representation of an object.
Servers should convert recognized schemas to the latest internal value, and
may reject unrecognized values.
More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources
type: string
kind:
description: |-
Kind is a string value representing the REST resource this object represents.
Servers may infer this from the endpoint the client submits requests to.
Cannot be updated.
In CamelCase.
More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds
type: string
metadata:
type: object
spec:
description: spec is the specification for the AWSEndpointService.
properties:
networkLoadBalancerName:
description: |-
networkLoadBalancerName is the name of the NLB for which an Endpoint Service should be configured
NetworkLoadBalancerName is the name of the network load balancer.
maxLength: 255
type: string
resourceTags:
description: resourceTags is the list of tags to apply to the EndpointService
items:
description: AWSResourceTag is a tag to apply to AWS resources created
for the cluster.
properties:
key:
description: key is the key of the tag.
maxLength: 128
minLength: 1
pattern: ^[0-9A-Za-z_.:/=+-@]+$
type: string
value:
description: |-
value is the value of the tag.

Some AWS service do not support empty values. Since tags are added to
resources in many services, the length of the tag value must meet the
requirements of all services.
maxLength: 256
minLength: 1
pattern: ^[0-9A-Za-z_.:/=+-@]+$
type: string
required:
- key
- value
type: object
maxItems: 25
type: array
subnetIDs:
description: subnetIDs is the list of subnet IDs to which guest nodes
can attach
items:
maxLength: 63
type: string
maxItems: 10
type: array
required:
- networkLoadBalancerName
type: object
status:
description: status is the status of the AWSEndpointService.
properties:
conditions:
description: |-
conditions contains details for the current state of the Endpoint Service
request If there is an error processing the request e.g. the NLB doesn't
exist, then the Available condition will be false, reason AWSErrorReason,
and the error reported in the message.

Current condition types are: "Available"
items:
description: Condition contains details for one aspect of the current
state of this API Resource.
properties:
lastTransitionTime:
description: |-
lastTransitionTime is the last time the condition transitioned from one status to another.
This should be when the underlying condition changed. If that is not known, then using the time when the API field changed is acceptable.
format: date-time
type: string
message:
description: |-
message is a human readable message indicating details about the transition.
This may be an empty string.
maxLength: 32768
type: string
observedGeneration:
description: |-
observedGeneration represents the .metadata.generation that the condition was set based upon.
For instance, if .metadata.generation is currently 12, but the .status.conditions[x].observedGeneration is 9, the condition is out of date
with respect to the current state of the instance.
format: int64
minimum: 0
type: integer
reason:
description: |-
reason contains a programmatic identifier indicating the reason for the condition's last transition.
Producers of specific condition types may define expected values and meanings for this field,
and whether the values are considered a guaranteed API.
The value should be a CamelCase string.
This field may not be empty.
maxLength: 1024
minLength: 1
pattern: ^[A-Za-z]([A-Za-z0-9_,:]*[A-Za-z0-9_])?$
type: string
status:
description: status of the condition, one of True, False, Unknown.
enum:
- "True"
- "False"
- Unknown
type: string
type:
description: type of condition in CamelCase or in foo.example.com/CamelCase.
maxLength: 316
pattern: ^([a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*/)?(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])$
type: string
required:
- lastTransitionTime
- message
- reason
- status
- type
type: object
maxItems: 10
type: array
x-kubernetes-list-map-keys:
- type
x-kubernetes-list-type: map
dnsNames:
description: dnsNames are the names for the records created in the
hypershift private zone
items:
maxLength: 253
type: string
maxItems: 10
type: array
dnsZoneID:
description: dnsZoneID is ID for the hypershift private zone
maxLength: 255
type: string
endpointID:
description: endpointID is the ID of the Endpoint created in the guest
VPC
maxLength: 255
type: string
endpointServiceName:
description: |-
endpointServiceName is the name of the Endpoint Service created in the
management VPC
maxLength: 255
type: string
securityGroupID:
description: |-
securityGroupID is the ID for the VPC endpoint SecurityGroup
SecurityGroupID is the ID of the security group.
maxLength: 255
type: string
type: object
type: object
served: true
storage: true
subresources:
status: {}
53 changes: 53 additions & 0 deletions cmd/install/assets/hypershift-operator/certificatesigningrequestapprovals.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
api.openshift.io/merged-by-featuregates: "true"
include.release.openshift.io/ibm-cloud-managed: "true"
include.release.openshift.io/self-managed-high-availability: "true"
name: certificatesigningrequestapprovals.hypershift.openshift.io
spec:
group: hypershift.openshift.io
names:
kind: CertificateSigningRequestApproval
listKind: CertificateSigningRequestApprovalList
plural: certificatesigningrequestapprovals
shortNames:
- csra
- csras
singular: certificatesigningrequestapproval
scope: Namespaced
versions:
- name: v1beta1
schema:
openAPIV3Schema:
description: CertificateSigningRequestApproval defines the desired state of
CertificateSigningRequestApproval
properties:
apiVersion:
description: |-
APIVersion defines the versioned schema of this representation of an object.
Servers should convert recognized schemas to the latest internal value, and
may reject unrecognized values.
More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources
type: string
kind:
description: |-
Kind is a string value representing the REST resource this object represents.
Servers may infer this from the endpoint the client submits requests to.
Cannot be updated.
In CamelCase.
More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds
type: string
metadata:
type: object
spec:
description: spec is the specification of the desired behavior of the
CertificateSigningRequestApproval.
type: object
status:
description: status is the most recently observed status of the CertificateSigningRequestApproval.
type: object
type: object
served: true
storage: true
Loading