-
Notifications
You must be signed in to change notification settings - Fork 30
Group dependabot updates by package origin #690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Add k8s and openshift groups to consolidate related package updates: - k8s: Groups k8s.io/* and sigs.k8s.io/* packages - openshift: Groups github.com/openshift/* packages - other-go-modules: Catches remaining dependencies 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
WalkthroughIntroduces dependency update grouping in Dependabot configuration. Creates three groups for organizing go module dependencies: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/dependabot.yml (1)
15-21: Effective catch-all group with proper exclusions.The
other-go-modulesgroup correctly uses a wildcard pattern with exclusions to capture all remaining dependencies while avoiding overlap with thek8sandopenshiftgroups. The wildcard and exclude-patterns logic is sound.Consider adding
update-typesordependency-typeconstraints to theother-go-modulesgroup to limit grouped PR size, since a bare wildcard may result in very large grouped PRs across many unrelated modules.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (1)
.github/dependabot.yml
🔇 Additional comments (1)
.github/dependabot.yml (1)
7-14: LGTM! Clean grouping strategy for Kubernetes and OpenShift dependencies.The
k8sandopenshiftgroups are well-defined and use appropriate patterns to consolidate related package updates. This will effectively reduce PR noise by grouping coordinated updates from the same ecosystems.
|
@sebrandon1: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/LGTM |
|
@msherif1234: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@msherif1234: changing LGTM is restricted to collaborators DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: msherif1234, sebrandon1 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary
k8s.io/*andsigs.k8s.io/*packages together for coordinated updatesgithub.com/openshift/*packages togetherother-go-modulesgroupThis reduces PR noise and makes dependency updates easier to review.
Related PRs
This change is part of a coordinated effort across multiple OpenShift repositories:
Tracked by: CNFCERT-1301
Test plan
🤖 Generated with Claude Code