CORS-4055: migrate default region check to AWS SDK v2 #10267

tthvo · 2026-01-28T15:10:25Z

The PR is an incremental step to migrate AWS API calls to AWS SDK v2. This only focuses on logics to get the default region from loaded config for the survey.

Note: This code path is applicable for the survey that asks the users for the install region.

openshift-ci-robot · 2026-01-28T15:10:30Z

@tthvo: This pull request references CORS-4055 which is a valid jira issue.

Details

In response to this:

The PR is an incremental step to migrate AWS API calls to AWS SDK v2. This only focuses on logics to get the default region from loaded config for the survey.

Note: This code path is applicable for the survey that asks the users for the install region.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tthvo · 2026-01-28T15:13:12Z

/cc @yunjiang29
/label platform/aws

tthvo · 2026-01-28T15:16:03Z

I did a quick local test and it worked as expected 👇

Minimal run - Default region should be from the AWS profile

 ./openshift-install create install-config --dir=.
? SSH Public Key <path>
? Platform aws
INFO Credentials loaded from the AWS config using "SharedConfigCredentials: <path>" provider 
? Region  [Use arrows to move, type to filter, ? for more help]
  me-south-1 (Middle East (Bahrain))
  mx-central-1 (Mexico (Central))
  sa-east-1 (South America (São Paulo))
> us-east-1 (US East (N. Virginia))
  us-east-2 (US East (Ohio))
  us-west-1 (US West (N. California))
  us-west-2 (US West (Oregon))

Explicit region - Default region should be the specified region

$ AWS_REGION=us-west-1 ./openshift-install create install-config --dir=.
? SSH Public Key <path>
? Platform aws
INFO Credentials loaded from the AWS config using "SharedConfigCredentials: <path>" provider 
? Region  [Use arrows to move, type to filter, ? for more help]
  me-south-1 (Middle East (Bahrain))
  mx-central-1 (Mexico (Central))
  sa-east-1 (South America (São Paulo))
  us-east-1 (US East (N. Virginia))
  us-east-2 (US East (Ohio))
> us-west-1 (US West (N. California))
  us-west-2 (US West (Oregon))

Explicit invalid region - Default region should fall back to `us-east-1`

AWS_REGION=us-west-13 ./openshift-install create install-config --dir=.
? SSH Public Key <path>
? Platform aws
INFO Credentials loaded from the AWS config using "SharedConfigCredentials: <path>" provider 
WARNING Unrecognized AWS region "us-west-13", defaulting to us-east-1 
? Region  [Use arrows to move, type to filter, ? for more help]
  me-south-1 (Middle East (Bahrain))
  mx-central-1 (Mexico (Central))
  sa-east-1 (South America (São Paulo))
> us-east-1 (US East (N. Virginia))
  us-east-2 (US East (Ohio))
  us-west-1 (US West (N. California))
  us-west-2 (US West (Oregon))

tthvo · 2026-01-28T19:17:56Z

/retest

yunjiang29 · 2026-01-29T03:22:17Z

@liweinan can you do a pre-merge test against this PR?

liweinan · 2026-01-30T08:50:58Z

Verification process:

weli@tower ~/works/oc-swarm/installer (release-4.20) 
❯ git checkout CORS-4055-region  
Updating files: 100% (48308/48308), done.
branch 'CORS-4055-region' set up to track 'thvo/CORS-4055-region'.
Switched to a new branch 'CORS-4055-region'

weli@tower ~/works/oc-swarm/installer (CORS-4055-region) 
❯ hack/build.sh
++ dirname hack/build.sh
+ . hack/build-cluster-api.sh
++ set -e
+++ go env GOOS
+++ go env GOARCH
++ TARGET_OS_ARCH=darwin_arm64
++ CLUSTER_API_BIN_DIR=/Users/weli/works/oc-swarm/installer/cluster-api/bin/darwin_arm64
++ CLUSTER_API_MIRROR_DIR=/Users/weli/works/oc-swarm/installer/pkg/clusterapi/mirror/
++ ENVTEST_K8S_VERSION=1.32.0
+++ go env GOOS

+ go build -mod=vendor -gcflags '' -ldflags ' -X github.com/openshift/installer/pkg/version.Raw=v1.4.21-pre-154-g0ef07df61901d7b2e0857378101730de80c5db80 -X github.com/openshift/installer/pkg/version.Commit=0ef07df61901d7b2e0857378101730de80c5db80 -X github.com/openshift/installer/pkg/version.defaultArch=amd64 -s -w' -tags ' release' -o bin/openshift-install ./cmd/openshift-install

weli@tower ~/works/oc-swarm/installer/bin (CORS-4055-region) 
❯ ./openshift-install version
./openshift-install v1.4.21-pre-154-g0ef07df61901d7b2e0857378101730de80c5db80
built from commit 0ef07df61901d7b2e0857378101730de80c5db80
release image registry.ci.openshift.org/origin/release:4.21
WARNING Release Image Architecture not detected. Release Image Architecture is unknown 
release architecture unknown
default architecture amd64

❯ aws configure get region
us-east-1
weli@tower ~/works/oc-swarm/installer/bin (CORS-4055-region) 
❯ ./openshift-install create install-config
? SSH Public Key /Users/weli/.ssh/id_rsa.pub
? Platform aws
INFO Credentials loaded from the AWS config using "SharedConfigCredentials: /Users/weli/.aws/credentials" provider 
? Region  [Use arrows to move, type to filter, ? for more help]
  me-south-1 (Middle East (Bahrain))
  mx-central-1 (Mexico (Central))
  sa-east-1 (South America (São Paulo))
> us-east-1 (US East (N. Virginia))
  us-east-2 (US East (Ohio))
  us-west-1 (US West (N. California))
  us-west-2 (US West (Oregon))

weli@tower ~/works/oc-swarm/installer/bin (CORS-4055-region) 
❯ AWS_REGION=us-west-1 ./openshift-install create install-config --dir=.
? SSH Public Key /Users/weli/.ssh/id_rsa.pub
? Platform aws
INFO Credentials loaded from the AWS config using "SharedConfigCredentials: /Users/weli/.aws/credentials" provider 
? Region  [Use arrows to move, type to filter, ? for more help]
  me-south-1 (Middle East (Bahrain))
  mx-central-1 (Mexico (Central))
  sa-east-1 (South America (São Paulo))
  us-east-1 (US East (N. Virginia))
  us-east-2 (US East (Ohio))
> us-west-1 (US West (N. California))
  us-west-2 (US West (Oregon))

weli@tower ~/works/oc-swarm/installer/bin (CORS-4055-region) 
❯ AWS_REGION=us-west-404 ./openshift-install create install-config --dir=.
? SSH Public Key /Users/weli/.ssh/id_rsa.pub
? Platform aws
INFO Credentials loaded from the AWS config using "SharedConfigCredentials: /Users/weli/.aws/credentials" provider 
WARNING Unrecognized AWS region "us-west-404", defaulting to us-east-1 
? Region  [Use arrows to move, type to filter, ? for more help]
  me-south-1 (Middle East (Bahrain))
  mx-central-1 (Mexico (Central))
  sa-east-1 (South America (São Paulo))
> us-east-1 (US East (N. Virginia))
  us-east-2 (US East (Ohio))
  us-west-1 (US West (N. California))
  us-west-2 (US West (Oregon))

liweinan · 2026-01-30T08:51:39Z

/verified by liweinan

openshift-ci-robot · 2026-01-30T08:51:50Z

@liweinan: This PR has been marked as verified by liweinan.

Details

In response to this:

/verified by liweinan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pkg/asset/installconfig/aws/platform.go

patrickdillon

/approve
/lgtm

openshift-ci · 2026-01-30T22:02:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

The commit is an incremental step to migrate AWS API calls to AWS SDK v2. This only focuses on logics to get the default region from loaded config for the survey.

openshift-ci · 2026-01-31T02:36:38Z

@tthvo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn	`3330f83`	link	true	`/test e2e-aws-ovn`
ci/prow/e2e-aws-ovn-edge-zones	`3330f83`	link	false	`/test e2e-aws-ovn-edge-zones`
ci/prow/images	`3330f83`	link	true	`/test images`
ci/prow/e2e-aws-ovn-heterogeneous	`3330f83`	link	false	`/test e2e-aws-ovn-heterogeneous`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

liweinan · 2026-01-31T03:11:37Z

Verification:

weli@tower ~/works/oc-swarm/installer/bin (CORS-4055-region) 
❯ ./openshift-install version
./openshift-install v1.4.21-pre-158-g3330f83b95bc1e72753ac254ee5cca00b6b9ceba
built from commit 3330f83b95bc1e72753ac254ee5cca00b6b9ceba
release image registry.ci.openshift.org/origin/release:4.21
WARNING Release Image Architecture not detected. Release Image Architecture is unknown 
release architecture unknown
default architecture amd64
weli@tower ~/works/oc-swarm/installer/bin (CORS-4055-region) 
❯ aws configure get region
us-east-1
weli@tower ~/works/oc-swarm/installer/bin (CORS-4055-region) 

---

weli@tower ~/works/oc-swarm/installer/bin (CORS-4055-region) 
❯ ./openshift-install create install-config
? SSH Public Key /Users/weli/.ssh/id_rsa.pub
? Platform aws
INFO Credentials loaded from the AWS config using "SharedConfigCredentials: /Users/weli/.aws/credentials" provider 
? Region  [Use arrows to move, type to filter, ? for more help]
  me-south-1 (Middle East (Bahrain))
  mx-central-1 (Mexico (Central))
  sa-east-1 (South America (São Paulo))
> us-east-1 (US East (N. Virginia))
  us-east-2 (US East (Ohio))
  us-west-1 (US West (N. California))
  us-west-2 (US West (Oregon))

---

weli@tower ~/works/oc-swarm/installer/bin (CORS-4055-region) 
❯ AWS_REGION=us-west-1 ./openshift-install create install-config --dir=.
? SSH Public Key /Users/weli/.ssh/id_rsa.pub
? Platform aws
INFO Credentials loaded from the AWS config using "SharedConfigCredentials: /Users/weli/.aws/credentials" provider 
? Region  [Use arrows to move, type to filter, ? for more help]
  me-south-1 (Middle East (Bahrain))
  mx-central-1 (Mexico (Central))
  sa-east-1 (South America (São Paulo))
  us-east-1 (US East (N. Virginia))
  us-east-2 (US East (Ohio))
> us-west-1 (US West (N. California))
  us-west-2 (US West (Oregon))

---

weli@tower ~/works/oc-swarm/installer/bin (CORS-4055-region) 
❯ AWS_REGION=us-west-404 ./openshift-install create install-config --dir=.
? SSH Public Key /Users/weli/.ssh/id_rsa.pub
? Platform aws
INFO Credentials loaded from the AWS config using "SharedConfigCredentials: /Users/weli/.aws/credentials" provider 
WARNING Unrecognized AWS region "us-west-404", defaulting to us-east-1 
? Region  [Use arrows to move, type to filter, ? for more help]
  me-south-1 (Middle East (Bahrain))
  mx-central-1 (Mexico (Central))
  sa-east-1 (South America (São Paulo))
> us-east-1 (US East (N. Virginia))
  us-east-2 (US East (Ohio))
  us-west-1 (US West (N. California))
  us-west-2 (US West (Oregon))

liweinan · 2026-01-31T03:12:51Z

/verified by liweinan

openshift-ci-robot · 2026-01-31T03:13:01Z

@liweinan: This PR has been marked as verified by liweinan.

Details

In response to this:

/verified by liweinan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

liweinan · 2026-01-31T03:13:29Z

/lgtm

openshift-ci-robot · 2026-01-31T03:33:04Z

/retest-required

Remaining retests: 0 against base HEAD 5314736 and 2 for PR HEAD 3330f83 in total

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 28, 2026

openshift-ci bot requested review from barbacbd and patrickdillon January 28, 2026 15:12

openshift-ci bot requested a review from yunjiang29 January 28, 2026 15:13

openshift-ci bot added the platform/aws label Jan 28, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 30, 2026

patrickdillon reviewed Jan 30, 2026

View reviewed changes

pkg/asset/installconfig/aws/platform.go Outdated Show resolved Hide resolved

patrickdillon reviewed Jan 30, 2026

View reviewed changes

openshift-ci bot assigned patrickdillon Jan 30, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2026

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2026

CORS-4055: migrate default region check to AWS SDK v2

3330f83

The commit is an incremental step to migrate AWS API calls to AWS SDK v2. This only focuses on logics to get the default region from loaded config for the survey.

tthvo force-pushed the CORS-4055-region branch from 0ef07df to 3330f83 Compare January 30, 2026 22:30

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Jan 30, 2026

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 31, 2026

openshift-ci bot assigned liweinan Jan 31, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2026

CORS-4055: migrate default region check to AWS SDK v2 #10267

Are you sure you want to change the base?

CORS-4055: migrate default region check to AWS SDK v2 #10267

Conversation

tthvo commented Jan 28, 2026

Uh oh!

openshift-ci-robot commented Jan 28, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tthvo commented Jan 28, 2026

Uh oh!

tthvo commented Jan 28, 2026

Minimal run - Default region should be from the AWS profile

Explicit region - Default region should be the specified region

Explicit invalid region - Default region should fall back to us-east-1

Uh oh!

tthvo commented Jan 28, 2026

Uh oh!

yunjiang29 commented Jan 29, 2026

Uh oh!

liweinan commented Jan 30, 2026

Uh oh!

liweinan commented Jan 30, 2026

Uh oh!

openshift-ci-robot commented Jan 30, 2026

Uh oh!

Uh oh!

patrickdillon left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jan 30, 2026

Uh oh!

openshift-ci bot commented Jan 31, 2026

Uh oh!

liweinan commented Jan 31, 2026

Uh oh!

liweinan commented Jan 31, 2026

Uh oh!

openshift-ci-robot commented Jan 31, 2026

Uh oh!

liweinan commented Jan 31, 2026

Uh oh!

openshift-ci-robot commented Jan 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

openshift-ci-robot commented Jan 28, 2026 •

edited by openshift-ci bot

Loading

Explicit invalid region - Default region should fall back to `us-east-1`