OCPBUGS-74390: Allow all instance types in the install config for GCP #10271
Conversation
openshift-ci-robot
added
jira/severity-important
|
@barbacbd: This pull request references Jira Issue OCPBUGS-74390, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-robot
added
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
barbacbd
force-pushed
the
OCPBUGS-74390
branch
from
624a0fd to
d073cb3
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@barbacbd: This pull request references Jira Issue OCPBUGS-74390, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
barbacbd
force-pushed
the
OCPBUGS-74390
branch
from
d073cb3 to
c956744
Compare
| diskTypes, ok := gcp.InstanceTypeToDiskTypeMap[family] | ||
| if !ok { | ||
| return field.NotFound(fldPath.Child("type"), family) | ||
| logrus.Warnf("unrecognized instance type: %s", family) |
There was a problem hiding this comment.
| logrus.Warnf("unrecognized instance type: %s", family) | |
| logrus.Warnf("Skipping disk type validation for unsupported instance type family %s", family) |
| InstanceTypeToDiskTypeMap = map[string][]string{ | ||
| "a2": {PDStandard, PDSSD, PDBalanced}, | ||
| "a3": {PDSSD, PDBalanced}, | ||
| "c2": {PDStandard, PDSSD, PDBalanced}, | ||
| "c2d": {PDStandard, PDSSD, PDBalanced}, | ||
| "c3": {PDSSD, PDBalanced, HyperDiskBalanced}, | ||
| "c3d": {PDSSD, PDBalanced, HyperDiskBalanced}, | ||
| "c4": {HyperDiskBalanced}, | ||
| "c4a": {HyperDiskBalanced}, | ||
| "e2": {PDStandard, PDSSD, PDBalanced}, | ||
| "g2": {PDStandard, PDSSD, PDBalanced}, | ||
| "m1": {PDSSD, PDBalanced, HyperDiskBalanced}, | ||
| // General Purpose Machine Family |
There was a problem hiding this comment.
Let's keep this list as a tracker for tested instance type? We should only update this when QE confirms with testing.
There was a problem hiding this comment.
It's ok for these lists to be independent... Anything that is in the tested list should absolutely work, but it is ok for instance types to work that are not in the list.
There was a problem hiding this comment.
What about this validation? Do we want to allow all ARM family?
|
/cc @jianli-wei |
barbacbd
force-pushed
the
OCPBUGS-74390
branch
from
c956744 to
06ad09b
Compare
|
@barbacbd: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
** validation.go: Correct the error message to provide all supported instance types when one is not found. ** machinepools.go Update the map to include all instance types and the supported disk types. The unsupported disk types are in comments in the map. These are to be updated when/if openshift supports these disktypes in the future.
barbacbd
force-pushed
the
OCPBUGS-74390
branch
from
06ad09b to
462072d
Compare
5 participants
** validation.go:
Correct the error message to provide all supported instance types when one is not found.
** machinepools.go
Update the map to include all instance types and the supported disk types. The unsupported disk types are in comments in the map. These are to be updated when/if openshift supports these disktypes in the future.