Skip to content

OCPBUGS-74677: [release-4.17] GCP: skip AI zones #10276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patrickdillon wants to merge 1 commit into
base: release-4.17
Choose a base branch
from
+10 −1
Open

OCPBUGS-74677: [release-4.17] GCP: skip AI zones #10276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion pkg/asset/installconfig/gcp/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ func GetZones(ctx context.Context, svc *compute.Service, project, region string)
defer cancel()
if err := req.Pages(ctx, func(page *compute.ZoneList) error {
for _, zone := range page.Items {
if strings.HasSuffix(zone.Region, region) && strings.EqualFold(zone.Status, "UP") {
if strings.HasSuffix(zone.Region, region) && strings.EqualFold(zone.Status, "UP") && !aiZone(zone.Name) {
zones = append(zones, zone)
}
}
Expand Down Expand Up @@ -562,3 +562,12 @@ func (c *Client) GetNamespacedTagValue(ctx context.Context, tagNamespacedName st

return tagValue, nil
}

// aiZone returns true if the GCP zone follows the AI naming convention.
// Uses the regular expression pattern as documented in GCP API docs:
// "To match zones containing ai in their name, use the filter query parameter with the regular expression name eq '.*-ai.*'."
// e.g. us-south1-ai1b, us-central1-ai1a.
// See: https://docs.cloud.google.com/compute/docs/regions-zones/ai-zones
func aiZone(zone string) bool {
return strings.Contains(zone, "-ai")
}