Merge upstream #716
Closed
Merge upstream #716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: e-minguez <e.minguez@gmail.com>
This simple change allows us to build ironic containers using CS10 base images, adding that as supported OS. This has been tested locally and in CI. Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
…ixes metal3-io#627 Signed-off-by: Brian Oldfield <boldfield@nvidia.com>
Signed-off-by: Brian Oldfield <boldfield@nvidia.com>
Signed-off-by: Brian Oldfield <boldfield@nvidia.com>
Signed-off-by: Brian Oldfield <boldfield@nvidia.com>
Signed-off-by: Brian Oldfield <boldfield@nvidia.com>
Passing a password in clear text is an obviously bad idea. Add support for mounting a secret and deprecate the clear text approach. This change also makes it a fatal error to not pass the password. Our mariadb-image does not support empty passwords anyway, and we should not rely on anyone actually using "change_me" without realizing it. Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
⚠️ Deprecate passing MARIADB_PASSWORD in favour of mounting a secret
✨ Install shim-pkg explicitly and add support for CentOS Stream 10
The new entrypoints rundatabase-upgrade and runonline-data-migrations are designed to be run as a Job every time Ironic is upgraded. See also: https://docs.openstack.org/ironic/latest/admin/upgrade-guide.html Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
Previously, it defaults to true for a split API/conductor deployment, but this mode is no longer supported. Most deployments use a single Ironic process and SQLite as a backend. Update README with the relevant parameters. Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
If upgrades are managed by IrSO, Ironic should not do them again. In an environment with several Ironic instances it will cause a race. Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
⚠️ Set IRONIC_USE_MARIADB to false by default in all cases
🌱 Refactoring: add a helper for restarting a service on certificate update
…efined Signed-off-by: Brian Oldfield <boldfield@nvidia.com>
✨ Add scripts to run database upgrades and online migrations
We release sushy-tools 2.0.0 last week, let's update the version we use in Metal3 Signed-off-by: Iury Gregory Melo Ferreira <imelofer@redhat.com>
🌱 Update sushy-tools to 2.0.0
…ig-tweaks 🐛 Allow override of `http_url`, etc for different network topologies
Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
This commit: - Introduces an environment variable that will cause all configuration files to be relocated under the specified location. - Introduces a .gitignore file in order to exclude temporary files from version control. - Converts the probes to be parameterized via environment variables thus removes the need for jinja templates. - A few configuration template files that were copied to /etc during image building have been moved to /tmp to keep the root of /etc more organized. This commit is needed in order to turn the ironic container compatible with K8s readOnlyRootFilesystem pod security context. Signed-off-by: Adam Rozman <adam.rozman@est.tech>
Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
🌱 Update virtualbmc version to 3.2.0
✨ Add build ironic-image with CentOS Stream 10
✨ Add support for custom configuration directories
This reverts commit d534678. Newly added syntax breaks the builds for entire repo. We have 5 images built here, so I'm reverting this and we'll reintroduce the patch. Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
🐛 Revert "Add build ironic-image with CentOS Stream 10"
Signed-off-by: Lennart Jern <lennart.jern@est.tech>
…ager 🌱 Do not install dnf config-manager
Mount cache dir at build time to reuse it during DNF runs. Also clean dnf cache at the end of the build. Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
Add Renovate documentation to releasing.md. There will be no prior art yet on updating the renovate.json when release is cut, and also branch pinning PR needs update after next release cut, as previous pinning PR did pin branch and not SHA. Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
Add Renovate bot configuration for doing updates to main once per week, on Mondays. Migrate the configuration to the latest configuration format as well. Upstream Ironic is getting updates almost every day and that would be too many PRs to merge and manage. Once per week is enough, and if a developer wants newer upstream Ironic, they can add the required SHA in their PR as a bump. Add initial upstream SHA pin. Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
🌱 add weekly renovate to main and documentation
These two have completely different roles: WEBSERVER_VERIFY_CA is used by Ironic to check user images. Unless your image happens to be on a server that uses the same CA, this is not a valid default. Also fix README: WEBSERVER_VERIFY_CA is not used by IPA. Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
🐛 Stop defaulting WEBSERVER_VERIFY_CA to IRONIC_CACERT_FILE
Bumps the github-actions group with 1 update: [softprops/action-gh-release](https://github.com/softprops/action-gh-release). Updates `softprops/action-gh-release` from 2.3.3 to 2.4.1 - [Release notes](https://github.com/softprops/action-gh-release/releases) - [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md) - [Commits](softprops/action-gh-release@6cbd405...6da8fa9) --- updated-dependencies: - dependency-name: softprops/action-gh-release dependency-version: 2.4.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com>
This commit: - Adds checklist that asks documentation and integration tests - Adds Steps to follow section Signed-off-by: Sunnatillo <sunnat.samadov@est.tech>
…ions/main/github-actions-e74af9633e 🌱 Bump softprops/action-gh-release from 2.3.3 to 2.4.1 in the github-actions group
…or node as the current path /var/lib/ironic/master_iso_images is read-only when read-only root filesystem is enabled for ironic-image Signed-off-by: Himanshu Roy <hroy@redhat.com>
Previous manual bump did accidentally PIN upstream Ironic to a SHA from July, instead of HEAD. This bumps it to HEAD~1, so we can debug why renovate didn't push a PR to correct the SHA. Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
🐛 bump upstream Ironic to a SHA from Nov 6
caches. This will fix the device cross links errors when hard linking. Signed-off-by: Himanshu Roy <hroy@redhat.com>
🐛 Use custom data directory to store the master iso images on ironic-conductor node
…plate 🌱 Update to Pull request template
🌱 Optimize DNF usage
Setting this value is important for stable branches, both for the version-specific logic in IrSO itself and for skipping tests that cannot run on this branch. Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
📖 Releasing: set IRONIC_CUSTOM_IMAGE in the IrSO job
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: honza The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@honza: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.