METAL-1104: Guard against empty BMC CA volume #726
Conversation
If the ConfigMap is mounted as optional, it will end up in an empty directory, and `cat dir/*` will fail on it. Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com> (cherry picked from commit a1495fc)
openshift-ci-robot
added
the
jira/valid-reference
|
@dtantsur: This pull request references METAL-1104 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
/test images |
1 similar comment
|
/test images |
|
/retest-required |
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
|
/verified by @dtantsur I've tested this patch on dev-scripts together with openshift/cluster-baremetal-operator#527 and the older merged installer patch, both with and without openshift-metal3/dev-scripts#1812. |
openshift-ci-robot
added
the
verified
|
@dtantsur: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-metal-ipi-bm |
1 similar comment
|
/test e2e-metal-ipi-bm |
|
/hold Revision 3be4fe1 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@dtantsur: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
If the ConfigMap is mounted as optional, it will end up in an empty
directory, and
cat dir/*will fail on it.Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com
(cherry picked from commit a1495fc)